Bug 143779 - [Win] DRT does not seem to reset the 'UsesPageCache' setting between tests
Summary: [Win] DRT does not seem to reset the 'UsesPageCache' setting between tests
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL:
Keywords:
Depends on:
Blocks: 143463
  Show dependency tree / graph
 
Reported: 2015-04-15 09:42 PDT by Chris Dumez
Modified: 2015-04-15 17:27 PDT (History)
2 users (show)

See Also:

Attachments
Patch (1.58 KB, patch)
2015-04-15 09:45 PDT, Chris Dumez 		no flags Details | Formatted Diff | Diff
Patch (1.57 KB, patch)
2015-04-15 09:47 PDT, Chris Dumez 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2015-04-15 09:42:40 PDT 
DRT does not seem to reset the 'UsesPageCache' settings between tests on Windows. This should be done in resetWebPreferencesToConsistentValues() in DumpRenderTree.cpp, similarly to what is done in DumpRenderTree.mm on Mac / WK1.
Without test, PageCache could stay enabled after page cache tests (They enable PageCache explicitly via 'testRunner.overridePreference("WebKitUsesPageCachePreferenceKey", 1)') and cause weird behaviors.
Comment 1 Chris Dumez 2015-04-15 09:45:06 PDT 
Created attachment 250800 [details]
Patch
Comment 2 Chris Dumez 2015-04-15 09:47:07 PDT 
Created attachment 250801 [details]
Patch
Comment 3 Brent Fulgham 2015-04-15 09:50:34 PDT 
Comment on attachment 250801 [details]
Patch

r=me.
Comment 4 Chris Dumez 2015-04-15 09:54:59 PDT 
Comment on attachment 250801 [details]
Patch

Clearing flags on attachment: 250801

Committed r182844: <http://trac.webkit.org/changeset/182844>
Comment 5 Chris Dumez 2015-04-15 09:55:03 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 6 Chris Dumez 2015-04-15 17:26:13 PDT 
FYI, after this change. The number of new passes went from 28 to 32 on the Windows Debug bot. Also, the flakes went down from 9 to 1. Similar results on the Windows Release bot.

So it looks like the change was indeed useful :)
Comment 7 Brent Fulgham 2015-04-15 17:27:18 PDT 
I'm also wondering if (In reply to comment #6)
> FYI, after this change. The number of new passes went from 28 to 32 on the
> Windows Debug bot. Also, the flakes went down from 9 to 1. Similar results
> on the Windows Release bot.
> 
> So it looks like the change was indeed useful :)

That's wonderful news! I wonder if I can re-enable a few of the tests I identified as messing up the page cache previously. All of those symptoms might have been caused by this bug you found.