Bug 143771 - [W32] windowsVersion() and osVersionForUAString() are outdated
Summary: [W32] windowsVersion() and osVersionForUAString() are outdated
Status: NEW
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks: 133028
  Show dependency tree / graph
 
Reported: 2015-04-15 06:33 PDT by LRN
Modified: 2015-09-14 11:14 PDT (History)
3 users (show)

See Also:

Attachments
Update windowsVersion() and osVersionForUAString() (7.96 KB, patch)
2015-04-15 10:14 PDT, LRN 		no flags Details | Formatted Diff | Diff
Update windowsVersion() and osVersionForUAString() (8.08 KB, patch)
2015-04-15 13:16 PDT, LRN 		lrn1986: commit-queue?
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description LRN 2015-04-15 06:33:19 PDT 
../webkitgtk-2.4.8/Source/WebCore/platform/win/SystemInfo.cpp: In function 'WTF::String WebCore::osVersionForUAString()':
../webkitgtk-2.4.8/Source/WebCore/platform/win/SystemInfo.cpp:94:12: warning: enumeration value 'WindowsCE5' not handled in switch [-Wswitch]
repeated for each unhandled value
Comment 1 LRN 2015-04-15 10:14:17 PDT 
Created attachment 250818 [details]
Update windowsVersion() and osVersionForUAString()

Add support for newer Windows versions to windowsVersion(), handle all
defined cases in osVersionForUAString(), avoiding warnings like
../webkitgtk-2.4.8/Source/WebCore/platform/win/SystemInfo.cpp: In function 'WTF::String WebCore::osVersionForUAString()':
../webkitgtk-2.4.8/Source/WebCore/platform/win/SystemInfo.cpp:94:12: warning: enumeration value 'WindowsCE5' not handled in switch [-Wswitch]
repeated for each unhandled value
Comment 2 WebKit Commit Bot 2015-04-15 10:16:05 PDT 
Attachment 250818 [details] did not pass style-queue:


ERROR: Source/WebCore/platform/win/SystemInfo.cpp:74:  Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons.  [readability/comparison_to_zero] [5]
ERROR: Source/WebCore/platform/win/SystemInfo.cpp:82:  Multi line control clauses should use braces.  [whitespace/braces] [4]
ERROR: Source/WebCore/ChangeLog:16:  You should remove the 'No new tests' and either add and list tests, or explain why no new tests were possible.  [changelog/nonewtests] [5]
Total errors found: 3 in 3 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 LRN 2015-04-15 13:16:32 PDT 
Created attachment 250843 [details]
Update windowsVersion() and osVersionForUAString()

Add support for newer Windows versions to windowsVersion(), handle all
defined cases in osVersionForUAString(), avoiding warnings like
../webkitgtk-2.4.8/Source/WebCore/platform/win/SystemInfo.cpp: In function 'WTF::String WebCore::osVersionForUAString()':
../webkitgtk-2.4.8/Source/WebCore/platform/win/SystemInfo.cpp:94:12: warning: enumeration value 'WindowsCE5' not handled in switch [-Wswitch]
repeated for each unhandled value
Comment 4 Carlos Garcia Campos 2015-05-18 09:49:03 PDT 
Committed to 2.4 http://trac.webkit.org/changeset/184490
Comment 5 Csaba Osztrogonác 2015-09-14 11:14:20 PDT 
Comment on attachment 250818 [details]
Update windowsVersion() and osVersionForUAString()

Cleared Darin Adler's review+ from obsolete attachment 250818 [details] so that this bug does not appear in http://webkit.org/pending-commit.