Bug 143767 - [W32] Configure may misdetect ICU libraries
Summary: [W32] Configure may misdetect ICU libraries
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks: 133028
  Show dependency tree / graph
 
Reported: 2015-04-15 06:29 PDT by LRN
Modified: 2015-05-18 10:52 PDT (History)
2 users (show)

See Also:

Attachments
Try to use pkg-config to detect ICU libraries (2.55 KB, patch)
2015-04-15 10:06 PDT, LRN 		cgarcia: review+
cgarcia: commit-queue-
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description LRN 2015-04-15 06:29:55 PDT 
MinGW packages tend to have .pc files these days. Use them.

ICU naming and structure is complex enough to warrant this, and asking
pkg-config might result in things like
UNICODE_LIBS="-licui18n54 -licuuc54 -licudata54"
instead of the default
UNICODE_LIBS="-licui18n -licuuc"
and pkg-config usually knows best.
Comment 1 LRN 2015-04-15 10:06:41 PDT 
Created attachment 250813 [details]
Try to use pkg-config to detect ICU libraries

MinGW packages tend to have .pc files these days. Use them.

ICU naming and structure is complex enough to warrant this, and asking
pkg-config might result in things like
UNICODE_LIBS="-licui18n54 -licuuc54 -licudata54"
instead of the default
UNICODE_LIBS="-licui18n -licuuc"
and pkg-config usually knows best.
Comment 2 Carlos Garcia Campos 2015-05-18 10:52:41 PDT 
Committed in 2.4 http://trac.webkit.org/changeset/184502