RESOLVED FIXED 143767
[W32] Configure may misdetect ICU libraries 
https://bugs.webkit.org/show_bug.cgi?id=143767
Summary [W32] Configure may misdetect ICU libraries
LRN
Reported 2015-04-15 06:29:55 PDT
MinGW packages tend to have .pc files these days. Use them. ICU naming and structure is complex enough to warrant this, and asking pkg-config might result in things like UNICODE_LIBS="-licui18n54 -licuuc54 -licudata54" instead of the default UNICODE_LIBS="-licui18n -licuuc" and pkg-config usually knows best.
Attachments
Try to use pkg-config to detect ICU libraries (2.55 KB, patch)
2015-04-15 10:06 PDT, LRN 		cgarcia: review+
cgarcia: commit-queue-
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
LRN
Comment 1 2015-04-15 10:06:41 PDT
Created attachment 250813 [details] Try to use pkg-config to detect ICU libraries MinGW packages tend to have .pc files these days. Use them. ICU naming and structure is complex enough to warrant this, and asking pkg-config might result in things like UNICODE_LIBS="-licui18n54 -licuuc54 -licudata54" instead of the default UNICODE_LIBS="-licui18n -licuuc" and pkg-config usually knows best.
Carlos Garcia Campos
Comment 2 2015-05-18 10:52:41 PDT
Committed in 2.4 http://trac.webkit.org/changeset/184502
Note You need to log in before you can comment on or make changes to this bug.