Bug 143766 - [W32][ANGLE] Warnings during the build
Summary: [W32][ANGLE] Warnings during the build
Status: NEW
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks: 133028
  Show dependency tree / graph
 
Reported: 2015-04-15 06:29 PDT by LRN
Modified: 2016-07-07 12:17 PDT (History)
4 users (show)

See Also:

Attachments
Silence two warnings in ANGLE (3.96 KB, patch)
2015-04-15 10:05 PDT, LRN 		achristensen: review-
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description LRN 2015-04-15 06:29:17 PDT 
../webkitgtk-2.4.8/Source/ThirdParty/ANGLE/src/compiler/ParseContext.cpp:538:123: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]
     if (op == EOpConstructStruct && !type->isArray() && int(type->getStruct()->fields().size()) != function.getParamCount()) {
                                                                                                                           ^
../webkitgtk-2.4.8/Source/ThirdParty/ANGLE/src/compiler/depgraph/DependencyGraph.cpp:7:0: warning: ignoring #pragma warning  [-Wunknown-pragmas]
 #pragma warning(disable: 4718)
 ^
Comment 1 LRN 2015-04-15 10:05:14 PDT 
Created attachment 250812 [details]
Silence two warnings in ANGLE

../webkitgtk-2.4.8/Source/ThirdParty/ANGLE/src/compiler/ParseContext.cpp:538:123: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]
     if (op == EOpConstructStruct && !type->isArray() && int(type->getStruct()->fields().size()) != function.getParamCount()) {
                                                                                                                           ^
../webkitgtk-2.4.8/Source/ThirdParty/ANGLE/src/compiler/depgraph/DependencyGraph.cpp:7:0: warning: ignoring #pragma warning  [-Wunknown-pragmas]
 #pragma warning(disable: 4718)
 ^
Comment 2 Alex Christensen 2016-07-07 12:17:40 PDT 
Comment on attachment 250812 [details]
Silence two warnings in ANGLE

This patch no longer applies to ParseContext.cpp.  If the DependencyGraph.cpp change is still needed, please upload an updated patch.