WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
NEW
143765
Generator-scripts may use wrong compiler/preprocessor
https://bugs.webkit.org/show_bug.cgi?id=143765
Summary
Generator-scripts may use wrong compiler/preprocessor
LRN
Reported
2015-04-15 06:28:34 PDT
Various scripts check the CC environment variable to get the compiler to use. In absence of that variable they do various educated guesses. They guess wrong when running in MSYS (find /usr/bin/gcc instead of /mingw/bin/gcc) and likely also guess wrong when cross-compiling.
Attachments
Ensure that generator-scripts get CC from configure
(37.08 KB, patch)
2015-04-15 10:03 PDT
,
LRN
beidson
: review-
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
LRN
Comment 1
2015-04-15 10:03:49 PDT
Created
attachment 250811
[details]
Ensure that generator-scripts get CC from configure Various scripts check the CC environment variable to get the compiler to use. In absence of that variable they do various educated guesses. They guess wrong when running in MSYS (find /usr/bin/gcc instead of /mingw/bin/gcc) and likely also guess wrong when cross-compiling. Note that if the version of a "wrong" gcc is close enough to the "right" gcc, things might just work out somehow, but we shouldn't bet on that.
LRN
Comment 2
2015-04-21 04:22:11 PDT
There's an alternative patch for this issue in
https://bugs.webkit.org/show_bug.cgi?id=143908
While i believe that the patch from
bug 143908
is not entirely correct (for the explanation see
https://bugs.webkit.org/show_bug.cgi?id=133028#c38
), it does fix the immediate problem.
Brady Eidson
Comment 3
2017-04-24 19:07:00 PDT
Comment on
attachment 250811
[details]
Ensure that generator-scripts get CC from configure This patch has been pending review since 2015 with no recent activity. It seems unlikely that it would even still apply to trunk in its current form. Clearing from the review queue. Feel free to update and resubmit if the patch is still relevant.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug