Bug 143764 - [W32][GTK] GI fails due to W32-incompatible arguments to the scanner
Summary: [W32][GTK] GI fails due to W32-incompatible arguments to the scanner
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks: 133028
  Show dependency tree / graph
 
Reported: 2015-04-15 06:27 PDT by LRN
Modified: 2015-05-18 11:26 PDT (History)
2 users (show)

See Also:

Attachments
Use correct .la files as --library arguments for GI scanner (2.41 KB, patch)
2015-04-15 10:01 PDT, LRN 		cgarcia: review+
cgarcia: commit-queue-
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description LRN 2015-04-15 06:27:48 PDT 
It is given
--library=webkitgtk-@WEBKITGTK_API_VERSION@
--library=javascriptcoregtk-@WEBKITGTK_API_VERSION@
which doesn't work.

Instead it should be given
--library=libwebkitgtk-@WEBKITGTK_API_MAJOR_VERSION@.@WEBKITGTK_API_MINOR_VERSION@.la
--library=libjavascriptcoregtk-@WEBKITGTK_API_MAJOR_VERSION@.@WEBKITGTK_API_MINOR_VERSION@.la
which works.
Comment 1 LRN 2015-04-15 10:01:10 PDT 
Created attachment 250810 [details]
Use correct .la files as --library arguments for GI scanner

This way it plays well with W32 gobject-introspection library resolution
code.
Without that one would get things like:
ERROR: can't resolve libraries to shared libraries: webkitgtk-3.0, javascriptcoregtk-3.0
Comment 2 Carlos Garcia Campos 2015-05-18 11:26:23 PDT 
Committed to 2.4 http://trac.webkit.org/changeset/184504