Bug 143759 - [GTK][W32] FileSystemGtk calls GetModuleHandleExA(), but does not include appropriate header
Summary: [GTK][W32] FileSystemGtk calls GetModuleHandleExA(), but does not include app...
Status: NEW
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks: 133028
  Show dependency treegraph
 
Reported: 2015-04-15 06:20 PDT by LRN
Modified: 2017-03-11 10:45 PST (History)
4 users (show)

See Also:


Attachments
Add missing includes to FileSystemGtk (1.74 KB, patch)
2015-04-15 09:51 PDT, LRN
no flags Details | Formatted Diff | Diff
Add missing includes to FileSystemGtk (1.70 KB, patch)
2015-04-15 13:04 PDT, LRN
lrn1986: commit-queue?
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description LRN 2015-04-15 06:20:54 PDT
It needs to include <windows.h>
Comment 1 LRN 2015-04-15 09:51:53 PDT
Created attachment 250804 [details]
Add missing includes to FileSystemGtk

Needed for GetModuleHandleExA() & Co.
Comment 2 WebKit Commit Bot 2015-04-15 09:55:11 PDT
Attachment 250804 [details] did not pass style-queue:


ERROR: Source/WebCore/ChangeLog:12:  You should remove the 'No new tests' and either add and list tests, or explain why no new tests were possible.  [changelog/nonewtests] [5]
Total errors found: 1 in 2 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 LRN 2015-04-15 13:04:06 PDT
Created attachment 250839 [details]
Add missing includes to FileSystemGtk

Needed for GetModuleHandleExA() & Co.
Comment 4 Carlos Garcia Campos 2015-05-18 23:36:36 PDT
Committed to 2.4 http://trac.webkit.org/changeset/184549

I'm leaving this open, since this applies to trunk as well, but for trunk I think we should probably remove the windows implementation from FileSystemGtk instead, since it's currently dead code.
Comment 5 Csaba Osztrogonác 2015-09-14 11:14:14 PDT
Comment on attachment 250804 [details]
Add missing includes to FileSystemGtk

Cleared Darin Adler's review+ from obsolete attachment 250804 [details] so that this bug does not appear in http://webkit.org/pending-commit.