Bug 143755 - [W32] Buildsystem may use wrong Python interpreter
Summary: [W32] Buildsystem may use wrong Python interpreter
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks: 133028
  Show dependency treegraph
 
Reported: 2015-04-15 06:15 PDT by LRN
Modified: 2015-05-18 23:43 PDT (History)
2 users (show)

See Also:


Attachments
[W32] Use confgured Python interpreter (3.49 KB, patch)
2015-04-15 08:40 PDT, LRN
no flags Details | Formatted Diff | Diff
Use confgured Python interpreter (4.61 KB, patch)
2015-04-15 09:42 PDT, LRN
cgarcia: review+
cgarcia: commit-queue-
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description LRN 2015-04-15 06:15:27 PDT
Configure script has tests for Python (AC_PATH_PROG(PYTHON, python)), but makefiles just say "python" and let make finds whatever there is in PATH, so a wrong version of Python might be used. Mingw-python,
for example, which has commandline length limit, which results in
errors like:
/usr/bin/env: python: Argument list too long
GNUmakefile:82317: recipe for target
'DerivedSources/WebInspectorUI/GResourceBundle.xml' failed
Comment 1 LRN 2015-04-15 08:40:21 PDT
Created attachment 250790 [details]
[W32] Use confgured Python interpreter

Configure script has tests for Python (AC_PATH_PROG(PYTHON, python)),
use the interpretor they provide (which is overridable by user by
the way of passing PYTHON=... to configure) instead of the first
thing found in PATH.

Otherwise wrong version of Python might be used. Mingw-python,
for example, which has commandline length limit, which results in
errors like:
/usr/bin/env: python: Argument list too long
GNUmakefile:82317: recipe for target
'DerivedSources/WebInspectorUI/GResourceBundle.xml' failed
Comment 2 LRN 2015-04-15 09:42:39 PDT
Created attachment 250798 [details]
Use confgured Python interpreter

Configure script has tests for Python (AC_PATH_PROG(PYTHON, python)),
use the interpretor they provide (which is overridable by user by
the way of passing PYTHON=... to configure) instead of the first
thing found in PATH.

Otherwise wrong version of Python might be used. Mingw-python,
for example, which has commandline length limit, which results in
errors like:
/usr/bin/env: python: Argument list too long
GNUmakefile:82317: recipe for target
'DerivedSources/WebInspectorUI/GResourceBundle.xml' failed
Comment 3 Carlos Garcia Campos 2015-05-18 23:43:32 PDT
Committed to 2.4 http://trac.webkit.org/changeset/184551