Bug 143747 – JavaScriptCore: Use kCFAllocatorDefault where possible

• Status: RESOLVED
• Resolution: FIXED
• Component: JavaScriptCore

[Joseph Pecoraro]

* SUMMARY
Use kCFAllocatorDefault instead of NULL/0/nullptr where possible.

This came up as a review comment for one of my changes. There are only a few in JSC, the other frameworks can be addressed separately later.

[Joseph Pecoraro]

Created attachment 250771 [details]
[PATCH] Proposed Fix

[Alexey Proskuryakov]

I'm curious what the rationale is. Isn't 0 slightly faster?

[Joseph Pecoraro]

(In reply to comment #2)
> I'm curious what the rationale is. Isn't 0 slightly faster?

My rationale was "consistency and readability". In cases where the first parameter is an allocator, then specifying kCFAllocatorDefault removes any ambiguity that may exist if "0" or "nullptr" was used for the first argument.

That said, I don't really have strong opinions on this. It was brought up in a review on one of my patches.

[Darin Adler]

Comment on attachment 250771 [details]
[PATCH] Proposed Fix

This is the clearest and most correct way to write it, but oh so wordy. In my non-WebKit code I almost always used NULL for this.

[WebKit Commit Bot]

Comment on attachment 250771 [details]
[PATCH] Proposed Fix

Clearing flags on attachment: 250771

Committed r182847: <http://trac.webkit.org/changeset/182847>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.