Bug 143745 – Regression(r180020): Web Inspector crashes on pages that have a stylesheet with an invalid MIME type

• Status: RESOLVED
• Resolution: FIXED
• Component: CSS

[Chris Dumez]

Web Inspector crashes on pages that have a stylesheet with an invalid MIME type:
0   com.apple.JavaScriptCore      	0x00007fff8f0a9feb JSC::Yarr::interpret(JSC::Yarr::BytecodePattern*, WTF::String const&, unsigned int, unsigned int*) + 11
1   com.apple.JavaScriptCore      	0x00007fff8f220e39 Inspector::ContentSearchUtilities::findMagicComment(WTF::String const&, WTF::String const&) + 153
2   com.apple.JavaScriptCore      	0x00007fff8f221336 Inspector::ContentSearchUtilities::findStylesheetSourceMapURL(WTF::String const&) + 278
3   com.apple.WebCore             	0x00007fff8d3c4784 WebCore::InspectorPageAgent::sourceMapURLForResource(WebCore::CachedResource*) + 372
4   com.apple.WebCore             	0x00007fff8d3c6235 WebCore::InspectorPageAgent::buildObjectForFrameTree(WebCore::Frame*) + 805
5   com.apple.WebCore             	0x00007fff8d3c65ae non-virtual thunk to WebCore::InspectorPageAgent::getResourceTree(WTF::String&, WTF::RefPtr<Inspector::Protocol::Page::FrameResourceTree>&) + 30
6   com.apple.JavaScriptCore      	0x00007fff8f3e5ffd Inspector::PageBackendDispatcher::getResourceTree(long, Inspector::InspectorObject const&) + 93
7   com.apple.JavaScriptCore      	0x00007fff8f3e4c5a Inspector::PageBackendDispatcher::dispatch(long, WTF::String const&, WTF::Ref<Inspector::InspectorObject>&&) + 570
8   com.apple.JavaScriptCore      	0x00007fff8f3bcf2a Inspector::BackendDispatcher::dispatch(WTF::String const&) + 1722
9   com.apple.WebKit              	0x00007fff89110800 void IPC::handleMessage<Messages::WebInspector::SendMessageToBackend, WebKit::WebInspector, void (WebKit::WebInspector::*)(WTF::String const&)>(IPC::MessageDecoder&, WebKit::WebInspector*, void (WebKit::WebInspector::*)(WTF::String const&)) + 67
10  com.apple.WebKit              	0x00007fff88ffcbb2 IPC::Connection::dispatchMessage(std::__1::unique_ptr<IPC::MessageDecoder, std::__1::default_delete<IPC::MessageDecoder> >) + 102

Radar: <rdar://problem/20243916>

[Chris Dumez]

Created attachment 250767 [details]
Patch

[Joseph Pecoraro]

Comment on attachment 250767 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=250767&action=review

r=me!

> Source/WebCore/ChangeLog:10
> +        are not served with a CSS MIME type. Showing the Web inspector on a

Nit: "Showing the Web inspector" => "Showing Web Inspector"

> Source/WebCore/inspector/InspectorPageAgent.cpp:159
> +            // This can return a null String if the MIME type is invalid.

This comment should be on the line above. "This" is sheetText.

> LayoutTests/http/tests/inspector/css/bad-mime-type-expected.txt:1
> +Tests showing the Web Inspector on a page that has a stylesheet with an invalid MIME type.

Grammar: How about: "Tests that showing Web Inspector on a page that has a stylesheet with an invalid MIME type does not crash."

[Chris Dumez]

Committed r182829: <http://trac.webkit.org/changeset/182829>

[Alexey Proskuryakov]

This test always times out on Windows:

https://webkit-test-results.appspot.com/dashboards/flakiness_dashboard.html#showAllRuns=true&tests=http%2Ftests%2Finspector%2Fcss%2Fbad-mime-type.html

[Chris Dumez]

> FAIL: Timed out waiting for notifyDone to be called

Joe, do I need to do anything special for Windows?

[Chris Dumez]

Comment on attachment 250767 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=250767&action=review

> LayoutTests/http/tests/inspector/css/bad-mime-type.html:12
> +    InspectorTest.completeTest();

This test cannot get much simpler than this. I don't know why Windows would time out. Maybe completeTest() needs to be called in a setTimeout() for some reason?