Bug 143726 - Add SPI to clear HSTS hosts added since a date
Summary: Add SPI to clear HSTS hosts added since a date
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit API (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Brian Weinstein
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-04-14 14:15 PDT by Brian Weinstein
Modified: 2015-04-14 16:14 PDT (History)
3 users (show)

See Also:


Attachments
[PATCH] Fix (4.20 KB, patch)
2015-04-14 14:17 PDT, Brian Weinstein
andersca: review+
commit-queue: commit-queue-
Details | Formatted Diff | Diff
[PATCH] Fix with CFNetworkSPI.h (5.13 KB, patch)
2015-04-14 15:15 PDT, Brian Weinstein
andersca: review+
andersca: commit-queue+
Details | Formatted Diff | Diff
[PATCH] Fix v3 (5.13 KB, patch)
2015-04-14 15:37 PDT, Brian Weinstein
beidson: review+
buildbot: commit-queue-
Details | Formatted Diff | Diff
Archive of layout-test-results from ews102 for mac-mavericks (523.15 KB, application/zip)
2015-04-14 15:52 PDT, Build Bot
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Brian Weinstein 2015-04-14 14:15:29 PDT
We need SPI to clear HSTS hosts added since a date.

rdar://problem/16664597
Comment 1 Brian Weinstein 2015-04-14 14:17:54 PDT
Created attachment 250739 [details]
[PATCH] Fix
Comment 2 WebKit Commit Bot 2015-04-14 15:04:43 PDT
Comment on attachment 250739 [details]
[PATCH] Fix

Rejecting attachment 250739 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.appspot.com', '--bot-id=webkit-cq-02', 'build', '--no-clean', '--no-update', '--build-style=release', '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit

Last 500 characters of output:
ase/DerivedSources/WebKit2/WebProcessProxyMessageReceiver.cpp -o /Volumes/Data/EWS/WebKit/WebKitBuild/WebKit2.build/Release/WebKit.build/Objects-normal/x86_64/WebProcessProxyMessageReceiver.o

** BUILD FAILED **


The following build commands failed:
	CompileC /Volumes/Data/EWS/WebKit/WebKitBuild/WebKit2.build/Release/WebKit.build/Objects-normal/x86_64/WebProcessPoolCocoa.o UIProcess/Cocoa/WebProcessPoolCocoa.mm normal x86_64 objective-c++ com.apple.compilers.llvm.clang.1_0.compiler
(1 failure)

Full output: http://webkit-queues.appspot.com/results/6701337739788288
Comment 3 Brian Weinstein 2015-04-14 15:08:09 PDT
Oops. I’ll send out a new patch shortly that uses CFNetworkSPI.h instead of directly trying to import CFURLProtocolPriv.h.
Comment 4 Brian Weinstein 2015-04-14 15:15:01 PDT
Created attachment 250744 [details]
[PATCH] Fix with CFNetworkSPI.h
Comment 5 Brian Weinstein 2015-04-14 15:37:58 PDT
Created attachment 250747 [details]
[PATCH] Fix v3
Comment 6 Build Bot 2015-04-14 15:52:15 PDT
Comment on attachment 250747 [details]
[PATCH] Fix v3

Attachment 250747 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.appspot.com/results/4930151208976384

New failing tests:
compositing/scrolling/touch-scroll-to-clip.html
Comment 7 Build Bot 2015-04-14 15:52:18 PDT
Created attachment 250748 [details]
Archive of layout-test-results from ews102 for mac-mavericks

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews102  Port: mac-mavericks  Platform: Mac OS X 10.9.5
Comment 8 Brian Weinstein 2015-04-14 16:14:14 PDT
Committed in r182815.