Bug 143723 - ASSERT(frame().view() == this) assertion hit in FrameView::windowClipRect() on Windows bots
Summary: ASSERT(frame().view() == this) assertion hit in FrameView::windowClipRect() o...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-04-14 13:24 PDT by Chris Dumez
Modified: 2015-04-14 15:49 PDT (History)
4 users (show)

See Also:

Attachments
Patch (2.07 KB, patch)
2015-04-14 13:33 PDT, Chris Dumez 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2015-04-14 13:24:41 PDT 
ASSERT(frame().view() == this) assertion hit in FrameView::windowClipRect() on Windows bots:
0018eee8 05ff4290 064f14f7 0018ef44 00000001 WTF!WTFCrash+0x21
0018ef4c 05ff4952 0018ef58 00000001 0018ef9c WebKit!WebCore::FrameView::windowClipRect+0x40
0018ef90 05ff490f 0ebc3ea8 0018efbc 05ffa4ff WebKit!WebCore::FrameView::resumeVisibleImageAnimationsIncludingSubframes+0x32
0018ef9c 05ffa4ff 0ebc3ea8 0060aa90 006060c0 WebKit!WebCore::FrameView::viewportContentsChanged+0xf
0018efbc 05ff56bf 0ebc3ea8 0018efd4 06911367 WebKit!WebCore::FrameView::performPostLayoutTasks+0x12f
0018efc8 06911367 0d18bc60 0018efe4 067e0259 WebKit!WebCore::FrameView::postLayoutTimerFired+0xf
0018efd4 067e0259 0ebc3ea8 0d18bc60 0018effc WebKit!std::_Pmf_wrap<void (__thiscall WebCore::WebSocket::*)(void),void,WebCore::WebSocket>::operator()+0x17
0018efe4 067e00f5 00000000 00000000 0d18bc60 WebKit!std::_Bind<1,void,std::_Pmf_wrap<void (__thiscall WebCore::XMLHttpRequest::*)(void),void,WebCore::XMLHttpRequest>,WebCore::XMLHttpRequest *>::_Do_call<,0>+0x39
0018effc 067e0116 0d18bc60 0018f014 067e0a72 WebKit!std::_Bind<1,void,std::_Pmf_wrap<void (__thiscall WebCore::XMLHttpRequest::*)(void),void,WebCore::XMLHttpRequest>,WebCore::XMLHttpRequest *>::operator()<>+0x25
0018f008 067e0a72 0d18bc58 0018f020 05cd5f78 WebKit!std::_Callable_obj<std::_Bind<1,void,std::_Pmf_wrap<void (__thiscall WebCore::XMLHttpRequest::*)(void),void,WebCore::XMLHttpRequest>,WebCore::XMLHttpRequest *>,0>::_ApplyX<void>+0x16
0018f014 05cd5f78 0ebc4050 0018f02c 05cd6f32 WebKit!std::_Func_impl<std::_Callable_obj<std::_Bind<1,void,std::_Pmf_wrap<void (__thiscall WebCore::XMLHttpRequest::*)(void),void,WebCore::XMLHttpRequest>,WebCore::XMLHttpRequest *>,0>,std::allocator<std::_Func_class<void> >,void>::_Do_call+0x12
0018f020 05cd6f32 0ebc4018 0018f05c 066d341c WebKit!std::_Func_class<void>::operator()+0x28
0018f02c 066d341c d3d79865 41d54b72 00000000 WebKit!WebCore::Timer::fired+0x12
0018f05c 066d32f6 0018f06c 06ad16bf 0018f098 WebKit!WebCore::ThreadTimers::sharedTimerFiredInternal+0x11c
0018f064 06ad16bf 0018f098 76f862fa 003d074e WebKit!WebCore::ThreadTimers::sharedTimerFired+0x16
0018f06c 76f862fa 003d074e 0000c126 00000000 WebKit!WebCore::TimerWindowWndProc+0x7f

It started happening after <http://trac.webkit.org/changeset/182773> but it is likely timing related rather than an actual regression.
Comment 1 Chris Dumez 2015-04-14 13:33:45 PDT 
Created attachment 250733 [details]
Patch
Comment 2 Brent Fulgham 2015-04-14 13:37:09 PDT 
Comment on attachment 250733 [details]
Patch

Looks good. If it doesn't break any tests, please land it!
Comment 3 Chris Dumez 2015-04-14 13:55:36 PDT 
Comment on attachment 250733 [details]
Patch

Clearing flags on attachment: 250733

Committed r182807: <http://trac.webkit.org/changeset/182807>
Comment 4 Chris Dumez 2015-04-14 13:55:40 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 5 Chris Dumez 2015-04-14 15:49:32 PDT 
The Windows bot has recovered after this fix:
https://build.webkit.org/builders/Apple%20Win%207%20Debug%20%28Tests%29/builds/65702