Bug 143721 - Insert volume control in correct place after exiting wireless play
Summary: Insert volume control in correct place after exiting wireless play
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Media (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-04-14 12:55 PDT by Roger Fong
Modified: 2015-04-14 15:39 PDT (History)
3 users (show)

See Also:

Attachments
patch (1.67 KB, patch)
2015-04-14 12:57 PDT, Roger Fong 		darin: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Roger Fong 2015-04-14 12:55:24 PDT 
rdar://problem/20526106
Comment 1 Roger Fong 2015-04-14 12:57:47 PDT 
Created attachment 250728 [details]
patch
Comment 2 Darin Adler 2015-04-14 13:19:41 PDT 
Comment on attachment 250728 [details]
patch

Maybe we should use "display: none" styling to hide and show rather than DOM manipulation. That’s usually better if you want to preserve a certain ordering of the nodes.
Comment 3 Roger Fong 2015-04-14 14:36:47 PDT 
Roger that. Didn't realize that display: none actually removes things from the DOM.
http://trac.webkit.org/changeset/182812
Comment 4 Darin Adler 2015-04-14 15:39:27 PDT 
(In reply to comment #3)
> Roger that. Didn't realize that display: none actually removes things from
> the DOM.

It doesn’t remove things from the DOM. It removes them from the render tree, though, which usually accomplishes the same thing.