Bug 143713 – Generalize "isPlayingAudio" to include other media characteristics

• Status: RESOLVED
• Resolution: FIXED
• Component: Media

[Eric Carlson]

Generalize "isPlayingAudio" to include other media characteristics

[Eric Carlson]

Created attachment 250709 [details]
Proposed patch

[Jer Noble]

Comment on attachment 250709 [details]
Proposed patch

View in context: https://bugs.webkit.org/attachment.cgi?id=250709&action=review

r=me, with questions:

> Source/WebCore/page/Page.cpp:-111
> -#include "MediaPlaybackTargetPickerClient.h"

Is this really no longer needed?

> Source/WebCore/page/Page.cpp:1216
> -    chrome().client().isPlayingAudioDidChange(m_isPlayingAudio);
> +    chrome().client().isPlayingMediaDidChange(m_isPlayingAudio ? ChromeClient::IsPlayingAudio : ChromeClient::IsNotPlaying);
>  }

Are we going to add support for IsPlayingVideo and IsPlayingToExternalDevice in a follow-up patch?

[Eric Carlson]

Created attachment 250726 [details]
Patch for the landing.

[WebKit Commit Bot]

Attachment 250726 [details] did not pass style-queue:


ERROR: Source/WebKit2/UIProcess/API/C/WKPage.cpp:1938:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
ERROR: Source/WebKit2/UIProcess/API/C/WKPage.cpp:1938:  Extra space before [  [whitespace/braces] [5]
Total errors found: 2 in 20 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Eric Carlson]

Created attachment 250786 [details]
Patch for the bots.

[WebKit Commit Bot]

Attachment 250786 [details] did not pass style-queue:


ERROR: Source/WebKit2/UIProcess/API/C/WKPage.cpp:1938:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
ERROR: Source/WebKit2/UIProcess/API/C/WKPage.cpp:1938:  Extra space before [  [whitespace/braces] [5]
Total errors found: 2 in 21 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Eric Carlson]

Created attachment 250792 [details]
Another patch for the bots.

[WebKit Commit Bot]

Attachment 250792 [details] did not pass style-queue:


ERROR: Source/WebKit2/UIProcess/API/C/WKPage.cpp:1938:  Extra space before [  [whitespace/braces] [5]
ERROR: Source/WebKit2/UIProcess/API/gtk/WebKitWebView.cpp:3102:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
Total errors found: 2 in 22 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Eric Carlson]

Committed r182842: https://trac.webkit.org/r182842