Bug 143713 - Generalize "isPlayingAudio" to include other media characteristics
Summary: Generalize "isPlayingAudio" to include other media characteristics
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Media (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Eric Carlson
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-04-14 08:46 PDT by Eric Carlson
Modified: 2015-04-15 09:22 PDT (History)
2 users (show)

See Also:

Attachments
Proposed patch (12.50 KB, patch)
2015-04-14 08:59 PDT, Eric Carlson 		no flags Details | Formatted Diff | Diff
Patch for the landing. (30.37 KB, patch)
2015-04-14 12:50 PDT, Eric Carlson 		no flags Details | Formatted Diff | Diff
Patch for the bots. (42.97 KB, patch)
2015-04-15 05:46 PDT, Eric Carlson 		no flags Details | Formatted Diff | Diff
Another patch for the bots. (46.00 KB, patch)
2015-04-15 08:50 PDT, Eric Carlson 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Eric Carlson 2015-04-14 08:46:53 PDT 
Generalize "isPlayingAudio" to include other media characteristics
Comment 1 Eric Carlson 2015-04-14 08:59:45 PDT 
Created attachment 250709 [details]
Proposed patch
Comment 2 Jer Noble 2015-04-14 10:37:16 PDT 
Comment on attachment 250709 [details]
Proposed patch

View in context: https://bugs.webkit.org/attachment.cgi?id=250709&action=review

r=me, with questions:

> Source/WebCore/page/Page.cpp:-111
> -#include "MediaPlaybackTargetPickerClient.h"

Is this really no longer needed?

> Source/WebCore/page/Page.cpp:1216
> -    chrome().client().isPlayingAudioDidChange(m_isPlayingAudio);
> +    chrome().client().isPlayingMediaDidChange(m_isPlayingAudio ? ChromeClient::IsPlayingAudio : ChromeClient::IsNotPlaying);
>  }

Are we going to add support for IsPlayingVideo and IsPlayingToExternalDevice in a follow-up patch?
Comment 3 Eric Carlson 2015-04-14 12:50:01 PDT 
Created attachment 250726 [details]
Patch for the landing.
Comment 4 WebKit Commit Bot 2015-04-14 12:51:28 PDT 
Attachment 250726 [details] did not pass style-queue:


ERROR: Source/WebKit2/UIProcess/API/C/WKPage.cpp:1938:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
ERROR: Source/WebKit2/UIProcess/API/C/WKPage.cpp:1938:  Extra space before [  [whitespace/braces] [5]
Total errors found: 2 in 20 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 5 Eric Carlson 2015-04-15 05:46:35 PDT 
Created attachment 250786 [details]
Patch for the bots.
Comment 6 WebKit Commit Bot 2015-04-15 05:48:21 PDT 
Attachment 250786 [details] did not pass style-queue:


ERROR: Source/WebKit2/UIProcess/API/C/WKPage.cpp:1938:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
ERROR: Source/WebKit2/UIProcess/API/C/WKPage.cpp:1938:  Extra space before [  [whitespace/braces] [5]
Total errors found: 2 in 21 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 7 Eric Carlson 2015-04-15 08:50:51 PDT 
Created attachment 250792 [details]
Another patch for the bots.
Comment 8 WebKit Commit Bot 2015-04-15 08:52:32 PDT 
Attachment 250792 [details] did not pass style-queue:


ERROR: Source/WebKit2/UIProcess/API/C/WKPage.cpp:1938:  Extra space before [  [whitespace/braces] [5]
ERROR: Source/WebKit2/UIProcess/API/gtk/WebKitWebView.cpp:3102:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
Total errors found: 2 in 22 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 9 Eric Carlson 2015-04-15 09:21:42 PDT 
Committed r182842: https://trac.webkit.org/r182842