fast/sub-pixel/input-caret-on-subpixel-bound.html is flaky on debug WK2 bots. It's a reftest for editing, and caret is not drawn in actual result sometimes. There is a race between a caret blinking timer, and a timer in the test.
Created attachment 250694 [details] proposed fix I have a vague memory of us doing something special to always have the caret draw when dumping pixel results, but I cannot find any sign of that in the code.
There is a function in FrameSelection named setCaretBlinks which we could potentially call from Internals, but it's completely unused now, and may or may not work. Looks like it was accidentally added when upstreaming iOS code.
We should probably delete setCaretBlinks and supporting code, and if we want to disable blinking during tests, we should do that by supporting and tweaking NSTextInsertionPointBlinkPeriod/NSTextInsertionPointBlinkPeriodOn/NSTextInsertionPointBlinkPeriodOff.
Comment on attachment 250694 [details] proposed fix Clearing flags on attachment: 250694 Committed r182801: <http://trac.webkit.org/changeset/182801>
All reviewed patches have been landed. Closing bug.