Bug 143696 - Clean up: Share more code between asynchronous and synchronous NSTextInputClient code paths
Summary: Clean up: Share more code between asynchronous and synchronous NSTextInputCli...
Status: NEW
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: 528+ (Nightly build)
Hardware: Mac All
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-04-13 22:27 PDT by Daniel Bates
Modified: 2015-04-13 22:40 PDT (History)
3 users (show)

See Also:

Attachments
Patch (10.20 KB, patch)
2015-04-13 22:29 PDT, Daniel Bates 		ap: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Daniel Bates 2015-04-13 22:27:23 PDT 
We should share more code between the asynchronous and synchronous NSTextInputClient code paths.
Comment 1 Daniel Bates 2015-04-13 22:29:12 PDT 
Created attachment 250693 [details]
Patch
Comment 2 WebKit Commit Bot 2015-04-13 22:32:24 PDT 
Attachment 250693 [details] did not pass style-queue:


ERROR: Source/WebKit2/UIProcess/API/mac/WKView.mm:2285:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
ERROR: Source/WebKit2/UIProcess/API/mac/WKView.mm:2307:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
ERROR: Source/WebKit2/UIProcess/API/mac/WKView.mm:2345:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
ERROR: Source/WebKit2/UIProcess/API/mac/WKView.mm:2386:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
Total errors found: 4 in 2 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Alexey Proskuryakov 2015-04-13 22:40:16 PDT 
Comment on attachment 250693 [details]
Patch

rs=me