Bug 143691 – Replace JavaScriptCoreOutputConsoleMessagesToSystemConsole default with an SPI

• Status: RESOLVED
• Resolution: FIXED
• Component: JavaScriptCore

[Joseph Pecoraro]

* SUMMARY
Replace JavaScriptCoreOutputConsoleMessagesToSystemConsole default with an SPI.

Accessing the default using CFPreferences comes with a non-trivial amount of memory and overhead. It would be nice to get off of the preferences API here and move to something simpler, like an SPI.

There can be different approaches here:

  - Global log to system console setting - matches the existing default
  - Per context log to system console setting - more fine grained control

Seeing as the existing value was global, lets just make a global setting for this as well.

[Joseph Pecoraro]

Created attachment 250689 [details]
[PATCH] Proposed Fix

[Joseph Pecoraro]

<rdar://problem/20470092>

[Timothy Hatcher]

Comment on attachment 250689 [details]
[PATCH] Proposed Fix

Are there any clients that need to adopt? Safari?

[Joseph Pecoraro]

Created attachment 250765 [details]
[PATCH] Proposed Fix

Better version. This moves the setting to the new JSRemoteInspector.h private header and renames it to JSRemoteInspectorSetLogToSystemConsole.

[Geoffrey Garen]

Comment on attachment 250765 [details]
[PATCH] Proposed Fix

r=me

[Joseph Pecoraro]

http://trac.webkit.org/changeset/182826