Bug 143682 – Web Inspector: Auto-attach fails after r179562, initialization too late after dispatch

• Status: RESOLVED
• Resolution: FIXED
• Component: Web Inspector

[Joseph Pecoraro]

* SUMMARY
Auto-attach fails after r179562, initialization too late after dispatch.

The async initialization of the RemoteInspector singleton causes auto-attach to fail if for instance you have:

  int main() {
    [[[JSContext alloc] init] evaluateScript:@"debugger"];
    ...
  }

We should detect if we are on the main thread and do it synchronously, since that was the only reason we were dispatching to the main thread anyways.

[Radar WebKit Bug Importer]

<rdar://problem/20525746>

[Joseph Pecoraro]

Created attachment 250679 [details]
[PATCH] Proposed Fix

[Joseph Pecoraro]

Comment on attachment 250679 [details]
[PATCH] Proposed Fix

View in context: https://bugs.webkit.org/attachment.cgi?id=250679&action=review

> Source/JavaScriptCore/inspector/remote/RemoteInspector.mm:87
> -            dispatch_async(dispatch_get_main_queue(), ^{
> +            dispatch_block_t initialize = ^{

One could argue that we should just change the dispatch_async to be a dispatch_sync. I'm going to cq- while I think about that.

[Joseph Pecoraro]

> One could argue that we should just change the dispatch_async to be a
> dispatch_sync. I'm going to cq- while I think about that.

I couldn't reproduce the issue I was thinking with background queues, so I'm going to keep this dispatch_async in the non-main thread case.

[Joseph Pecoraro]

http://trac.webkit.org/changeset/182825