Bug 143671 - imported/w3c/canvas/2d.text.measure.width.empty.html is flaky
Summary: imported/w3c/canvas/2d.text.measure.width.empty.html is flaky
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Alexey Proskuryakov
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-04-13 10:21 PDT by Alexey Proskuryakov
Modified: 2015-04-13 17:08 PDT (History)
4 users (show)

See Also:


Attachments
proposed fix (6.18 KB, patch)
2015-04-13 10:33 PDT, Alexey Proskuryakov
no flags Details | Formatted Diff | Diff
proposed fix (7.21 KB, patch)
2015-04-13 14:25 PDT, Alexey Proskuryakov
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Alexey Proskuryakov 2015-04-13 10:21:37 PDT
We lack waitUntilDone/notifyDone for imported tests.

canvas/philip/tests/2d.text.measure.width.empty.html is good, but imported/w3c/canvas/2d.text.measure.width.empty.html usually fails (and only flakily passes on slow bots).
Comment 1 Alexey Proskuryakov 2015-04-13 10:33:30 PDT
Created attachment 250653 [details]
proposed fix

I don't know if it's correct to fix imported W3C tests like this, or if there is a script somewhere that would overwrite the fixes later.
Comment 2 youenn fablet 2015-04-13 10:55:47 PDT
(In reply to comment #1)
> Created attachment 250653 [details]
> proposed fix
> 
> I don't know if it's correct to fix imported W3C tests like this, or if
> there is a script somewhere that would overwrite the fixes later.

I encountered in the past some WPT tests that were missing testharness.js and testharnessreport.js includes. That may be a nicer way to handling such issues.
How is the latest WPT version?

In general, I would not recommend to modify scripts with webkit specific directives.
Comment 3 Alexey Proskuryakov 2015-04-13 11:04:52 PDT
> In general, I would not recommend to modify scripts with webkit specific directives.

Do you have a suggestion for how to fix this issue in a better way?
Comment 4 youenn fablet 2015-04-13 11:52:54 PDT
(In reply to comment #3)
> > In general, I would not recommend to modify scripts with webkit specific directives.
> 
> Do you have a suggestion for how to fix this issue in a better way?

If am not mistaken, the corresponding test is https://github.com/w3c/web-platform-tests/blob/master/2dcontext/drawing-text-to-the-canvas/2d.text.measure.width.empty.html
It now includes testharness.js/testharnessreport.js scripts.

Reimporting that test should solve the issue.
If it were me, I would reimport it into LayoutTests/imported/w3c/web-platform-tests/2dcontext
Comment 5 Alexey Proskuryakov 2015-04-13 14:25:55 PDT
Created attachment 250675 [details]
proposed fix

OK, updated the test from trunk. I don't know how to import, so I just copy/pasted it and updated the relative links.

Note that we already have some local edits related to testRunner in canvas-tests though, we should probably undo that at some point in the future.
Comment 6 WebKit Commit Bot 2015-04-13 17:08:35 PDT
Comment on attachment 250675 [details]
proposed fix

Clearing flags on attachment: 250675

Committed r182769: <http://trac.webkit.org/changeset/182769>
Comment 7 WebKit Commit Bot 2015-04-13 17:08:39 PDT
All reviewed patches have been landed.  Closing bug.