RESOLVED FIXED 143665
[cmake] REGRESSION(182663): It broke feature dependency handling 
https://bugs.webkit.org/show_bug.cgi?id=143665
Summary [cmake] REGRESSION(182663): It broke feature dependency handling
Csaba Osztrogonác
Reported 2015-04-13 06:24:13 PDT
Before http://trac.webkit.org/changeset/182663 the EFL --minimal build worked fine, because ENABLE_ENCRYPTED_MEDIA_V2 and ENABLE_MEDIA_CONTROLS_SCRIPT were disabled automatically by cmake: -- Disabling ENABLE_ENCRYPTED_MEDIA_V2 since ENABLE_VIDEO support is disabled. -- Disabling ENABLE_MEDIA_CONTROLS_SCRIPT since ENABLE_VIDEO support is disabled. But r182663 made something wrong, because these options aren't disabled automatically which cause build failure. Could you check what was going wrong?
Attachments
[cmake] REGRESSION(182663): It broke feature dependency handling (2.11 KB, patch)
2015-04-13 08:43 PDT, Michael Catanzaro 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Michael Catanzaro
Comment 1 2015-04-13 08:43:08 PDT
Created attachment 250640 [details] [cmake] REGRESSION(182663): It broke feature dependency handling
Michael Catanzaro
Comment 2 2015-04-13 08:44:02 PDT
This *isn't tested* because I have to run right now. I'll test it later today.
Csaba Osztrogonác
Comment 3 2015-04-13 08:55:42 PDT
Comment on attachment 250640 [details] [cmake] REGRESSION(182663): It broke feature dependency handling Thanks for the patch, it looks reasonable and fixes the issue I reported. If you can't see any other issue, feel free to land it.
WebKit Commit Bot
Comment 4 2015-04-13 10:43:38 PDT
Comment on attachment 250640 [details] [cmake] REGRESSION(182663): It broke feature dependency handling Clearing flags on attachment: 250640 Committed r182740: <http://trac.webkit.org/changeset/182740>
WebKit Commit Bot
Comment 5 2015-04-13 10:43:43 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.