Bug 143659 - String.prototype.startsWith/endsWith/includes have wrong length in r182673
Summary: String.prototype.startsWith/endsWith/includes have wrong length in r182673
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Jordan Harband
URL:
Keywords:
: 143660 (view as bug list)
Depends on:
Blocks:
 
Reported: 2015-04-12 23:06 PDT by Jordan Harband
Modified: 2015-04-15 17:16 PDT (History)
1 user (show)

See Also:

Attachments
Patch (6.25 KB, patch)
2015-04-15 16:18 PDT, Jordan Harband 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jordan Harband 2015-04-12 23:06:58 PDT 
In r182673 nightly, String.prototype.startsWith and String.prototype.endsWith both have a length of 0. According to https://people.mozilla.org/~jorendorff/es6-draft.html#sec-string.prototype.startswith and https://people.mozilla.org/~jorendorff/es6-draft.html#sec-string.prototype.endswith the length of both should explicitly be 1, since they have 1 required argument.
Comment 1 Jordan Harband 2015-04-15 16:04:06 PDT 
*** Bug 143660 has been marked as a duplicate of this bug. ***
Comment 2 Jordan Harband 2015-04-15 16:18:34 PDT 
Created attachment 250881 [details]
Patch
Comment 3 WebKit Commit Bot 2015-04-15 17:16:14 PDT 
Comment on attachment 250881 [details]
Patch

Clearing flags on attachment: 250881

Committed r182872: <http://trac.webkit.org/changeset/182872>
Comment 4 WebKit Commit Bot 2015-04-15 17:16:17 PDT 
All reviewed patches have been landed.  Closing bug.