Bug 143655 - Fixed position element is truncated if moved onscreen by a transform
Summary: Fixed position element is truncated if moved onscreen by a transform
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Simon Fraser (smfr)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-04-12 21:53 PDT by Simon Fraser (smfr)
Modified: 2015-04-13 10:56 PDT (History)
7 users (show)

See Also:

Attachments
Patch (5.58 KB, patch)
2015-04-12 21:56 PDT, Simon Fraser (smfr) 		darin: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Simon Fraser (smfr) 2015-04-12 21:53:47 PDT 
Fixed position element is truncated if moved onscreen by a transform
Comment 1 Simon Fraser (smfr) 2015-04-12 21:56:35 PDT 
Created attachment 250623 [details]
Patch
Comment 2 Simon Fraser (smfr) 2015-04-12 21:57:54 PDT 
rdar://problem/15020044
Comment 3 Darin Adler 2015-04-13 09:40:45 PDT 
Comment on attachment 250623 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=250623&action=review

> Source/WebCore/rendering/style/RenderStyle.cpp:485
> +        if (rareNonInheritedData->m_transform.get() != other.rareNonInheritedData->m_transform.get()) {

I’m surprised the get() are needed here.

> Source/WebCore/rendering/style/RenderStyle.cpp:488
> +            if (*rareNonInheritedData->m_transform.get() != *other.rareNonInheritedData->m_transform.get()) {

The get() should not be needed here.
Comment 4 Simon Fraser (smfr) 2015-04-13 10:56:29 PDT 
https://trac.webkit.org/r182743