Bug 143634 - Run flaky conservative GC related test first before polluting stack and registers
Summary: Run flaky conservative GC related test first before polluting stack and regis...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Yusuke Suzuki
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-04-11 10:41 PDT by Yusuke Suzuki
Modified: 2015-04-11 12:44 PDT (History)
8 users (show)

See Also:

Attachments
Patch (4.67 KB, patch)
2015-04-11 10:48 PDT, Yusuke Suzuki 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Yusuke Suzuki 2015-04-11 10:41:58 PDT 
Run flaky conservative GC related test first before polluting stack and registers
Comment 1 Yusuke Suzuki 2015-04-11 10:48:53 PDT 
Created attachment 250575 [details]
Patch
Comment 2 Yusuke Suzuki 2015-04-11 10:51:08 PDT 
This patch fixes https://build.webkit.org/builders/Apple%20Yosemite%20Debug%20JSC%20%28Tests%29?numbuilds=25 failures. However, we cannot avoid this flakiness completely since JSC GC is conservative.
Comment 3 Ryosuke Niwa 2015-04-11 11:51:03 PDT 
Comment on attachment 250575 [details]
Patch

It's sad that we can't test more realistic scenario but I can't think of a way around it.
Comment 4 WebKit Commit Bot 2015-04-11 12:44:32 PDT 
Comment on attachment 250575 [details]
Patch

Clearing flags on attachment: 250575

Committed r182661: <http://trac.webkit.org/changeset/182661>
Comment 5 WebKit Commit Bot 2015-04-11 12:44:38 PDT 
All reviewed patches have been landed.  Closing bug.