Bug 143621 - Hide volume controls when playing wirelessly
Summary: Hide volume controls when playing wirelessly
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Media (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-04-10 16:12 PDT by Roger Fong
Modified: 2015-04-10 23:25 PDT (History)
2 users (show)

See Also:

Attachments
patch (2.01 KB, patch)
2015-04-10 16:48 PDT, Roger Fong 		darin: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Roger Fong 2015-04-10 16:12:49 PDT 
Hide volume controls when playing wirelessly
Comment 1 Roger Fong 2015-04-10 16:13:17 PDT 
rdar://problem/20490673
Comment 2 Roger Fong 2015-04-10 16:48:12 PDT 
Created attachment 250540 [details]
patch
Comment 3 Darin Adler 2015-04-10 19:49:32 PDT 
Comment on attachment 250540 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=250540&action=review

> Source/WebCore/Modules/mediacontrols/mediaControlsApple.js:1776
> +                if (!this.controls.panel.contains(this.controls.volumeBox))

Would it be more efficient to check the parent of volumeBox rather than calling contains?
Comment 4 Roger Fong 2015-04-10 23:25:34 PDT 
True this. Committed with changes:
http://trac.webkit.org/changeset/182652