Bug 143616 – Update gesture swipe shadow style

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Tim Horton]

Update gesture swipe shadow style

[Tim Horton]

Created attachment 250528 [details]
Patch

[Tim Horton]

Created attachment 250534 [details]
Patch

[Tim Horton]

Comment on attachment 250534 [details]
Patch

Going to make some changes.

[Tim Horton]

Created attachment 250556 [details]
Patch

[Darin Adler]

Comment on attachment 250556 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=250556&action=review

A little surprised that the resources are not listed in the change log. Seems a little archaic that we have a 2x and a “regular” version of this. Not really sure why we don’t need a 3x and why we do need a 1x.

> Source/WebKit2/UIProcess/mac/ViewGestureControllerMac.mm:625
> +        [m_swipeDimmingLayer setName:@"Gesture Swipe Dimming Layer"];
> +        [m_swipeDimmingLayer setBackgroundColor:[NSColor blackColor].CGColor];
> +        [m_swipeDimmingLayer setOpacity:swipeOverlayDimmingOpacity];
> +        [m_swipeDimmingLayer setAnchorPoint:CGPointZero];
> +        [m_swipeDimmingLayer setFrame:dimmingRect];
> +        [m_swipeDimmingLayer setGeometryFlipped:geometryIsFlippedToRoot];
> +        [m_swipeDimmingLayer setDelegate:[WebActionDisablingCALayerDelegate shared]];

I’m surprised that we are using method call syntax rather than property setting syntax here.

[Tim Horton]

Comment on attachment 250556 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=250556&action=review

It sounds like we might get a CAGradientLayer instead of the PNGs soon, so hopefully the point about the resources will be rendered moot. That said, this is Mac code so that should explain why 1x and not 3x.

>> Source/WebKit2/UIProcess/mac/ViewGestureControllerMac.mm:625
>> +        [m_swipeDimmingLayer setDelegate:[WebActionDisablingCALayerDelegate shared]];
> 
> I’m surprised that we are using method call syntax rather than property setting syntax here.

They're RetainPtrs. My understanding is that we prefer [x setY:z] over x.get().y = z, but sadly I don't think that's written down anywhere.

[Tim Horton]

http://trac.webkit.org/changeset/182822