WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED CONFIGURATION CHANGED
143611
Remove use of deprecated stringByReplacingPercentEscapesUsingEncoding API.
https://bugs.webkit.org/show_bug.cgi?id=143611
Summary
Remove use of deprecated stringByReplacingPercentEscapesUsingEncoding API.
Enrica Casucci
Reported
2015-04-10 10:48:39 PDT
Needs to be replaced with stringByRemovingPercentEncoding, which always uses the recommended UTF-8 encoding.
Attachments
Patch
(1.64 KB, patch)
2015-04-10 10:58 PDT
,
Enrica Casucci
ap
: review-
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Enrica Casucci
Comment 1
2015-04-10 10:58:06 PDT
Created
attachment 250523
[details]
Patch
Alexey Proskuryakov
Comment 2
2015-04-10 11:12:50 PDT
Comment on
attachment 250523
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=250523&action=review
> Source/WebKit/mac/ChangeLog:9 > + We now use stringByRemovingPercentEncoding, which always > + uses the recommended UTF-8 encoding.
This looks like an undesirable change in behavior. When UTF-8 fails, we'll just get a null string, which is unacceptable. We should fall back to Latin-1 or maybe to keep the string percent encoded, I'm not sure what's actually best.
Anne van Kesteren
Comment 3
2024-08-27 08:24:29 PDT
> git grep stringByReplacingPercentEscapesUsingEncoding Source
crickets
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug