Bug 143611 - Remove use of deprecated stringByReplacingPercentEscapesUsingEncoding API.
Summary: Remove use of deprecated stringByReplacingPercentEscapesUsingEncoding API.
Status: NEW
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: iPhone / iPad Unspecified
: P2 Normal
Assignee: Enrica Casucci
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-04-10 10:48 PDT by Enrica Casucci
Modified: 2015-04-10 11:12 PDT (History)
1 user (show)

See Also:

Attachments
Patch (1.64 KB, patch)
2015-04-10 10:58 PDT, Enrica Casucci 		ap: review-
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Enrica Casucci 2015-04-10 10:48:39 PDT 
Needs to be replaced with stringByRemovingPercentEncoding, which always uses the recommended UTF-8 encoding.
Comment 1 Enrica Casucci 2015-04-10 10:58:06 PDT 
Created attachment 250523 [details]
Patch
Comment 2 Alexey Proskuryakov 2015-04-10 11:12:50 PDT 
Comment on attachment 250523 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=250523&action=review

> Source/WebKit/mac/ChangeLog:9
> +        We now use stringByRemovingPercentEncoding, which always
> +        uses the recommended UTF-8 encoding.

This looks like an undesirable change in behavior. When UTF-8 fails, we'll just get a null string, which is unacceptable.

We should fall back to Latin-1 or maybe to keep the string percent encoded, I'm not sure what's actually best.