Bug 143597 - [Curl] Small improvements to CurlCacheEntry::parseResponseHeaders()
Summary: [Curl] Small improvements to CurlCacheEntry::parseResponseHeaders()
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-04-09 22:53 PDT by Sungmann Cho
Modified: 2015-04-13 07:06 PDT (History)
4 users (show)

See Also:


Attachments
Patch (2.41 KB, patch)
2015-04-09 22:55 PDT, Sungmann Cho
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Sungmann Cho 2015-04-09 22:53:33 PDT
Most lines of code in CurlCacheEntry::parseResponseHeaders() don't need to be
executed if the response has "no-cache" or "no-store" directive, but we are
checking these conditions in the middle of the method. We can move this to the
beginning of the method for efficiency.
Comment 1 Sungmann Cho 2015-04-09 22:55:11 PDT
Created attachment 250501 [details]
Patch
Comment 2 Csaba Osztrogonác 2015-04-13 04:45:32 PDT
Comment on attachment 250501 [details]
Patch

LGTM, r=me.
Comment 3 WebKit Commit Bot 2015-04-13 07:06:37 PDT
Comment on attachment 250501 [details]
Patch

Clearing flags on attachment: 250501

Committed r182729: <http://trac.webkit.org/changeset/182729>
Comment 4 WebKit Commit Bot 2015-04-13 07:06:42 PDT
All reviewed patches have been landed.  Closing bug.