Bug 143595 - [CMake] Some internal variables are not marked as advanced
Summary: [CMake] Some internal variables are not marked as advanced
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC Linux
: P2 Normal
Assignee: Michael Catanzaro
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-04-09 20:58 PDT by Michael Catanzaro
Modified: 2015-04-23 13:31 PDT (History)
4 users (show)

See Also:


Attachments
[CMake] Some internal variables are not marked as advanced (1.79 KB, patch)
2015-04-09 21:00 PDT, Michael Catanzaro
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Michael Catanzaro 2015-04-09 20:58:43 PDT
The FindFreetype2 module uses find_path and find_library without marking the result as advanced, like all the other find* modules do. Also, FindHarfBuzz was updated to look for harfbuzz-icu without marking HARFBUZZ_ICU_LIBRARIES as advanced.
Comment 1 Michael Catanzaro 2015-04-09 21:00:12 PDT
Created attachment 250499 [details]
[CMake] Some internal variables are not marked as advanced
Comment 2 WebKit Commit Bot 2015-04-23 13:31:34 PDT
Comment on attachment 250499 [details]
[CMake] Some internal variables are not marked as advanced

Clearing flags on attachment: 250499

Committed r183206: <http://trac.webkit.org/changeset/183206>
Comment 3 WebKit Commit Bot 2015-04-23 13:31:38 PDT
All reviewed patches have been landed.  Closing bug.