RESOLVED FIXED 143593
[Cocoa] Add a HAVE(AVKIT) and use it
https://bugs.webkit.org/show_bug.cgi?id=143593
Summary [Cocoa] Add a HAVE(AVKIT) and use it
Andy Estes
Reported 2015-04-09 18:28:07 PDT
[Cocoa] Add a HAVE(AVKIT) and use it
Attachments
Patch (11.00 KB, patch)
2015-04-09 18:40 PDT, Andy Estes
ddkilzer: review+
Andy Estes
Comment 1 2015-04-09 18:37:24 PDT
Andy Estes
Comment 2 2015-04-09 18:40:04 PDT
David Kilzer (:ddkilzer)
Comment 3 2015-04-09 21:23:01 PDT
Comment on attachment 250494 [details] Patch r=me In the long term, we may not want to assume PLATFORM(IOS) is always defined when PLATFORM(WATCHOS) is defined, but this seems fine for now.
Andy Estes
Comment 4 2015-04-09 22:16:59 PDT
(In reply to comment #3) > Comment on attachment 250494 [details] > Patch > > r=me Thanks! > In the long term, we may not want to assume PLATFORM(IOS) is always defined > when PLATFORM(WATCHOS) is defined, but this seems fine for now. Yeah, I guess having PLATFORM(IOS) be true on Watch OS is a little like the old days of PLATFORM(MAC) being true on iOS. Ultimately we'd want a macro that represents all iOS-derived platforms, and another one that represents just iOS. Right now though, having PLATFORM(IOS) be true on Watch OS is a useful starting point.
Andy Estes
Comment 5 2015-04-10 01:34:38 PDT
Note You need to log in before you can comment on or make changes to this bug.