Bug 143592 - Pull emoji-position adjustment code into its own function
Summary: Pull emoji-position adjustment code into its own function
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Simon Fraser (smfr)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-04-09 18:14 PDT by Simon Fraser (smfr)
Modified: 2019-01-29 01:15 PST (History)
4 users (show)

See Also:

Attachments
Patch (4.61 KB, patch)
2015-04-09 18:14 PDT, Simon Fraser (smfr) 		mmaxfield: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Simon Fraser (smfr) 2015-04-09 18:14:06 PDT 
Pull emoji-position adjustment code into its own function
Comment 1 Simon Fraser (smfr) 2015-04-09 18:14:53 PDT 
Created attachment 250493 [details]
Patch
Comment 2 Myles C. Maxfield 2015-04-09 18:18:40 PDT 
Comment on attachment 250493 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=250493&action=review

> Source/WebCore/platform/graphics/cocoa/FontCascadeCocoa.mm:210
> +    if (platformData.m_isEmoji) {

Early return

> Source/WebCore/platform/graphics/cocoa/FontCascadeCocoa.mm:228
> +                y -= .35f * fontSize - 10;

Magic numbers :(
Comment 3 Simon Fraser (smfr) 2015-04-16 11:49:28 PDT 
https://trac.webkit.org/r182898