RESOLVED FIXED 143592
Pull emoji-position adjustment code into its own function 
https://bugs.webkit.org/show_bug.cgi?id=143592
Summary Pull emoji-position adjustment code into its own function
Simon Fraser (smfr)
Reported 2015-04-09 18:14:06 PDT
Pull emoji-position adjustment code into its own function
Attachments
Patch (4.61 KB, patch)
2015-04-09 18:14 PDT, Simon Fraser (smfr) 		mmaxfield: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Simon Fraser (smfr)
Comment 1 2015-04-09 18:14:53 PDT
Created attachment 250493 [details] Patch
Myles C. Maxfield
Comment 2 2015-04-09 18:18:40 PDT
Comment on attachment 250493 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=250493&action=review > Source/WebCore/platform/graphics/cocoa/FontCascadeCocoa.mm:210 > + if (platformData.m_isEmoji) { Early return > Source/WebCore/platform/graphics/cocoa/FontCascadeCocoa.mm:228 > + y -= .35f * fontSize - 10; Magic numbers :(
Simon Fraser (smfr)
Comment 3 2015-04-16 11:49:28 PDT
https://trac.webkit.org/r182898
Note You need to log in before you can comment on or make changes to this bug.