Bug 143590 – Minimum font size pref breaks SVG text very badly

• Status: RESOLVED
• Resolution: FIXED
• Component: SVG

[Said Abou-Hallawa]

Created attachment 250488 [details]
test case

Open the attached test case in Safari. Enable the "Never use font sizes smaller than:" pref in Safari preferences.

Result: The text is displayed with a very big font. Other examples are http://dbaron.org/log/20110225-blur-radius and http://orbis.stanford.edu. WebKit renders the text of these websites very badly if this perf is enabled.

[Said Abou-Hallawa]

Created attachment 250492 [details]
Patch

[Simon Fraser (smfr)]

Comment on attachment 250492 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=250492&action=review

> Source/WebCore/style/StyleFontSizeFunctions.cpp:44
> +static float computedFontSizeFromSpecifiedSize(float specifiedSize, bool isAbsoluteSize, bool canApplyMinSizeRules, float zoomFactor, ESmartMinimumForFontSize useSmartMinimumForFontSize, const Settings* settings)

The bool param makes it hard to read at the call site. An enum would be better.

[Said Abou-Hallawa]

Created attachment 250886 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 250886 [details]
Patch

Clearing flags on attachment: 250886

Committed r182876: <http://trac.webkit.org/changeset/182876>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Said Abou-Hallawa]

rdar://problem/13601274

[Darin Adler]

Comment on attachment 250886 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=250886&action=review

> Source/WebCore/ChangeLog:11
> +        computed value after applying the minimum fort size rule. This means the

font, not fort

> Source/WebCore/style/StyleFontSizeFunctions.cpp:43
> +    DonNotApplyMinimumFontSize,

Typo: DonNot.

> Source/WebCore/style/StyleFontSizeFunctions.cpp:48
> +static float computedFontSizeFromSpecifiedSize(float specifiedSize, bool isAbsoluteSize, float zoomFactor, MinimumFontSizeRule minimumForFontSizeRule, const Settings* settings)

I think the argument name should be minimumSizeRule rather than minimumForFontSizeRule. Other argument names just say Size, not FontSize, and the For is not needed.

[Said Abou-Hallawa]

(In reply to comment #7)
> Comment on attachment 250886 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=250886&action=review
> 
> > Source/WebCore/ChangeLog:11
> > +        computed value after applying the minimum fort size rule. This means the
> 
> font, not fort
> 
> > Source/WebCore/style/StyleFontSizeFunctions.cpp:43
> > +    DonNotApplyMinimumFontSize,
> 
> Typo: DonNot.
> 
> > Source/WebCore/style/StyleFontSizeFunctions.cpp:48
> > +static float computedFontSizeFromSpecifiedSize(float specifiedSize, bool isAbsoluteSize, float zoomFactor, MinimumFontSizeRule minimumForFontSizeRule, const Settings* settings)
> 
> I think the argument name should be minimumSizeRule rather than
> minimumForFontSizeRule. Other argument names just say Size, not FontSize,
> and the For is not needed.

Fixed. Committed r182955: <http://trac.webkit.org/changeset/182955>