WebCore should be built for all ports. So ENABLE_WEBCORE switch looks be redundant.
Created attachment 250474 [details] Patch
(In reply to comment #0) > WebCore should be built for all ports. So ENABLE_WEBCORE switch looks be > redundant. I am not sure but if I am right, it is to build jsc only. Someone may want to build only jsc to use stand-alone javascript engine without webcore. It can be usefull for javascript engine developers.
(In reply to comment #2) > (In reply to comment #0) > > WebCore should be built for all ports. So ENABLE_WEBCORE switch looks be > > redundant. > > I am not sure but if I am right, it is to build jsc only. > > Someone may want to build only jsc to use stand-alone javascript engine > without webcore. > It can be usefull for javascript engine developers. However I don't know who uses this option only to build jsc. Probably Ossy may use it. However Ossy doesn't use it. It looks nobody use it. Ossy, do you think ENABLE_WEBCORE is still needed for us ?
Comment on attachment 250474 [details] Patch I use Tools/Scripts/build-jsc to build only JSC, which generates the complete makefile/ninja.build and then call it to build only jsc target. build-jsc is happy with this change, so I can't see a reason to keep this condition. Additionally you can remove "set(ENABLE_WEBCORE ON)" from CMakeLists.txt:27 too.
For historical note http://trac.webkit.org/changeset/103417 introduced this option to be able build only jsc, http://trac.webkit.org/changeset/103464 added the build-jsc change and after http://trac.webkit.org/changeset/114508 this option became unused.
(In reply to comment #5) > For historical note http://trac.webkit.org/changeset/103417 introduced > this option to be able build only jsc, > http://trac.webkit.org/changeset/103464 > added the build-jsc change and after http://trac.webkit.org/changeset/114508 > this option became unused. Thanks for the clarifying.
Created attachment 250502 [details] Patch
Comment on attachment 250502 [details] Patch Thank you Ossy and Ryuan.
Comment on attachment 250502 [details] Patch Clearing flags on attachment: 250502 Committed r182624: <http://trac.webkit.org/changeset/182624>
All reviewed patches have been landed. Closing bug.