Bug 143584 - [CMake] Remove unnecessary ENABLE_WEBCORE switch
Summary: [CMake] Remove unnecessary ENABLE_WEBCORE switch
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Gyuyoung Kim
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-04-09 15:37 PDT by Gyuyoung Kim
Modified: 2015-04-10 01:37 PDT (History)
3 users (show)

See Also:

Attachments
Patch (3.24 KB, patch)
2015-04-09 15:38 PDT, Gyuyoung Kim 		no flags Details | Formatted Diff | Diff
Patch (3.69 KB, patch)
2015-04-10 00:21 PDT, Gyuyoung Kim 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Gyuyoung Kim 2015-04-09 15:37:05 PDT 
WebCore should be built for all ports. So ENABLE_WEBCORE switch looks be redundant.
Comment 1 Gyuyoung Kim 2015-04-09 15:38:00 PDT 
Created attachment 250474 [details]
Patch
Comment 2 Ryuan Choi 2015-04-09 17:01:46 PDT 
(In reply to comment #0)
> WebCore should be built for all ports. So ENABLE_WEBCORE switch looks be
> redundant.

I am not sure but if I am right, it is to build jsc only.

Someone may want to build only jsc to use stand-alone javascript engine without webcore.
It can be usefull for javascript engine developers.
Comment 3 Gyuyoung Kim 2015-04-09 19:32:18 PDT 
(In reply to comment #2)
> (In reply to comment #0)
> > WebCore should be built for all ports. So ENABLE_WEBCORE switch looks be
> > redundant.
> 
> I am not sure but if I am right, it is to build jsc only.
> 
> Someone may want to build only jsc to use stand-alone javascript engine
> without webcore.
> It can be usefull for javascript engine developers.

However I don't know who uses this option only to build jsc. Probably Ossy may use it. However Ossy doesn't use it. It looks nobody use it. Ossy, do you think ENABLE_WEBCORE is still needed for us ?
Comment 4 Csaba Osztrogonác 2015-04-09 23:45:01 PDT 
Comment on attachment 250474 [details]
Patch

I use Tools/Scripts/build-jsc to build only JSC, which generates the 
complete makefile/ninja.build and then call it to build only jsc target.

build-jsc is happy with this change, so I can't see a reason to keep this condition.

Additionally you can remove "set(ENABLE_WEBCORE ON)" from CMakeLists.txt:27 too.
Comment 5 Csaba Osztrogonác 2015-04-09 23:53:46 PDT 
For historical note http://trac.webkit.org/changeset/103417 introduced 
this option to be able build only jsc, http://trac.webkit.org/changeset/103464
added the build-jsc change and after http://trac.webkit.org/changeset/114508
this option became unused.
Comment 6 Ryuan Choi 2015-04-10 00:05:07 PDT 
(In reply to comment #5)
> For historical note http://trac.webkit.org/changeset/103417 introduced 
> this option to be able build only jsc,
> http://trac.webkit.org/changeset/103464
> added the build-jsc change and after http://trac.webkit.org/changeset/114508
> this option became unused.

Thanks for the clarifying.
Comment 7 Gyuyoung Kim 2015-04-10 00:21:24 PDT 
Created attachment 250502 [details]
Patch
Comment 8 Gyuyoung Kim 2015-04-10 00:50:30 PDT 
Comment on attachment 250502 [details]
Patch

Thank you Ossy and Ryuan.
Comment 9 WebKit Commit Bot 2015-04-10 01:37:47 PDT 
Comment on attachment 250502 [details]
Patch

Clearing flags on attachment: 250502

Committed r182624: <http://trac.webkit.org/changeset/182624>
Comment 10 WebKit Commit Bot 2015-04-10 01:37:52 PDT 
All reviewed patches have been landed.  Closing bug.