Bug 143553 - run-jsc-benchmarks geomean of preferred means shouldn't print the VMs header twice
Summary: run-jsc-benchmarks geomean of preferred means shouldn't print the VMs header ...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Filip Pizlo
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-04-08 20:44 PDT by Filip Pizlo
Modified: 2015-04-08 21:48 PDT (History)
13 users (show)

See Also:


Attachments
the patch (1.42 KB, patch)
2015-04-08 20:45 PDT, Filip Pizlo
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Filip Pizlo 2015-04-08 20:44:19 PDT
Since removing the overall arithmetic/geometric/harmonic averages, we print the VM header twice, like:

                                                        TipOfTree              FunctionRealloc                                  

                                                        TipOfTree              FunctionRealloc                                  
Geomean of preferred means:
   <scaled-result>                                   64.0958+-0.1805           63.8925+-0.1926          might be 1.0032x faster

We only need to print it once.
Comment 1 Filip Pizlo 2015-04-08 20:45:39 PDT
Created attachment 250408 [details]
the patch
Comment 2 WebKit Commit Bot 2015-04-08 21:48:20 PDT
Comment on attachment 250408 [details]
the patch

Clearing flags on attachment: 250408

Committed r182586: <http://trac.webkit.org/changeset/182586>
Comment 3 WebKit Commit Bot 2015-04-08 21:48:25 PDT
All reviewed patches have been landed.  Closing bug.