WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED DUPLICATE of
bug 143531
143522
[WinCairo] Fix a broken build due to the changes in
http://webkit.org/b/143316
https://bugs.webkit.org/show_bug.cgi?id=143522
Summary
[WinCairo] Fix a broken build due to the changes in http://webkit.org/b/143316
Sungmann Cho
Reported
2015-04-08 09:12:28 PDT
ToT currently breaks at: ..\platform\network\curl\CurlCacheEntry.cpp(293): error C2440: '=' : cannot convert from 'WTF::Optional<std::chrono::microseconds>' to 'double' No user-defined-conversion operator available that can perform this conversion, or the operator cannot be called ..\platform\network\curl\CurlCacheEntry.cpp(308): error C2440: '=' : cannot convert from 'WTF::Optional<std::chrono::system_clock::time_point>' to 'double' No user-defined-conversion operator available that can perform this conversion, or the operator cannot be called ..\platform\network\curl\CurlCacheEntry.cpp(312): error C2440: '=' : cannot convert from 'WTF::Optional<std::chrono::system_clock::time_point>' to 'double' No user-defined-conversion operator available that can perform this conversion, or the operator cannot be called ..\platform\network\curl\CurlCacheEntry.cpp(316): error C2440: '=' : cannot convert from 'WTF::Optional<std::chrono::system_clock::time_point>' to 'double' No user-defined-conversion operator available that can perform this conversion, or the operator cannot be called This is due to the changes in
http://webkit.org/b/143316
.
Attachments
Patch
(6.64 KB, patch)
2015-04-08 09:39 PDT
,
Sungmann Cho
no flags
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Sungmann Cho
Comment 1
2015-04-08 09:39:09 PDT
Created
attachment 250357
[details]
Patch
Peter Gal
Comment 2
2015-04-08 10:03:16 PDT
The code looks logically sane to me, but sadly I'm not a reviewer. Maybe Brent could do the review.
Sungmann Cho
Comment 3
2015-04-09 16:49:49 PDT
Thanks Peter! +bfulgham@ for review.
Brent Fulgham
Comment 4
2015-04-09 20:54:08 PDT
I think this might be a duplicate. Isn't this the same issue as
Bug 143531
?
Sungmann Cho
Comment 5
2015-04-09 21:34:08 PDT
Oops. Same patches were submitted on same day. Thanks for letting me know it. Close the issue.
Sungmann Cho
Comment 6
2015-04-09 21:34:34 PDT
*** This bug has been marked as a duplicate of
bug 143531
***
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug