Bug 143522 - [WinCairo] Fix a broken build due to the changes in http://webkit.org/b/143316
Summary: [WinCairo] Fix a broken build due to the changes in http://webkit.org/b/143316
Status: RESOLVED DUPLICATE of bug 143531
Alias: None
Product: WebKit
Classification: Unclassified
Component: Platform (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC Windows 8
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-04-08 09:12 PDT by Sungmann Cho
Modified: 2015-04-10 10:17 PDT (History)
4 users (show)

See Also:

Attachments
Patch (6.64 KB, patch)
2015-04-08 09:39 PDT, Sungmann Cho 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Sungmann Cho 2015-04-08 09:12:28 PDT 
ToT currently breaks at:
    ..\platform\network\curl\CurlCacheEntry.cpp(293): error C2440: '=' : cannot convert from 'WTF::Optional<std::chrono::microseconds>' to 'double'
            No user-defined-conversion operator available that can perform this conversion, or the operator cannot be called
    ..\platform\network\curl\CurlCacheEntry.cpp(308): error C2440: '=' : cannot convert from 'WTF::Optional<std::chrono::system_clock::time_point>' to 'double'
            No user-defined-conversion operator available that can perform this conversion, or the operator cannot be called
    ..\platform\network\curl\CurlCacheEntry.cpp(312): error C2440: '=' : cannot convert from 'WTF::Optional<std::chrono::system_clock::time_point>' to 'double'
            No user-defined-conversion operator available that can perform this conversion, or the operator cannot be called
    ..\platform\network\curl\CurlCacheEntry.cpp(316): error C2440: '=' : cannot convert from 'WTF::Optional<std::chrono::system_clock::time_point>' to 'double'
            No user-defined-conversion operator available that can perform this conversion, or the operator cannot be called

This is due to the changes in http://webkit.org/b/143316.
Comment 1 Sungmann Cho 2015-04-08 09:39:09 PDT 
Created attachment 250357 [details]
Patch
Comment 2 Peter Gal 2015-04-08 10:03:16 PDT 
The code looks logically sane to me, but sadly I'm not a reviewer. Maybe Brent could do the review.
Comment 3 Sungmann Cho 2015-04-09 16:49:49 PDT 
Thanks Peter!
+bfulgham@ for review.
Comment 4 Brent Fulgham 2015-04-09 20:54:08 PDT 
I think this might be a duplicate. Isn't this the same issue as Bug 143531?
Comment 5 Sungmann Cho 2015-04-09 21:34:08 PDT 
Oops. Same patches were submitted on same day.
Thanks for letting me know it.
Close the issue.
Comment 6 Sungmann Cho 2015-04-09 21:34:34 PDT 

*** This bug has been marked as a duplicate of bug 143531 ***