Expose the "Share" menu for links, images, and media In radar rdar://problem/20435340
Created attachment 250315 [details] Not ready for review, EWS run - v1
Attachment 250315 [details] did not pass style-queue: ERROR: Source/WebKit/win/WebCoreSupport/WebContextMenuClient.h:48: Tab found; better to use spaces [whitespace/tab] [1] Total errors found: 1 in 14 files If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 250356 [details] Not ready for review, EWS run - v2
Created attachment 250358 [details] Still an evolving WIP, still want EWS on the other platforms - v3
Attachment 250358 [details] did not pass style-queue: ERROR: Source/WebKit2/WebProcess/WebPage/WebPage.h:1089: The parameter name "result" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WebCore/platform/ContextMenuItem.cpp:79: Tab found; better to use spaces [whitespace/tab] [1] Total errors found: 2 in 19 files If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 250367 [details] For EWS, v4 As work continues, check on all the other builds again.
Attachment 250367 [details] did not pass style-queue: ERROR: Source/WebKit2/WebProcess/WebPage/WebPage.cpp:4876: Declaration has space between type name and * in Element *URLElement [whitespace/declaration] [3] ERROR: Source/WebKit2/WebProcess/WebPage/WebPage.cpp:4882: Declaration has space between type name and * in NSDictionary *options [whitespace/declaration] [3] ERROR: Source/WebKit2/WebProcess/WebPage/WebPage.cpp:4917: Declaration has space between type name and * in DDActionContext *actionContext [whitespace/declaration] [3] Total errors found: 3 in 20 files If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 250379 [details] For EWS, v5
Created attachment 250386 [details] Patch for review, v1
Attachment 250386 [details] did not pass style-queue: ERROR: Source/WebCore/ChangeLog:8: You should remove the 'No new tests' and either add and list tests, or explain why no new tests were possible. [changelog/nonewtests] [5] Total errors found: 1 in 27 files If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 250386 [details] Patch for review, v1 View in context: https://bugs.webkit.org/attachment.cgi?id=250386&action=review > Source/WebCore/platform/mac/ContextMenuItemMac.mm:207 > + [items.get() addObject:(NSURL *)absoluteLinkURL]; none of these .get()s in message sends are required or desirable > Source/WebKit2/WebProcess/WebPage/WebPage.h:873 > + void populateWebHitTestResult(const WebCore::HitTestResult&, bool includeImage, WebHitTestResult::Data&); I think it's pretty clear we're going to want to extend this and thus that the bool should be a bitflag instead, but I guess that can be later. Also, should this not just be a new WebHitTestResult::Data constructor with more arguments?
(In reply to comment #11) > Comment on attachment 250386 [details] > Patch for review, v1 > > View in context: > https://bugs.webkit.org/attachment.cgi?id=250386&action=review > > > Source/WebCore/platform/mac/ContextMenuItemMac.mm:207 > > + [items.get() addObject:(NSURL *)absoluteLinkURL]; > > none of these .get()s in message sends are required or desirable Duh! > > > Source/WebKit2/WebProcess/WebPage/WebPage.h:873 > > + void populateWebHitTestResult(const WebCore::HitTestResult&, bool includeImage, WebHitTestResult::Data&); > > I think it's pretty clear we're going to want to extend this and thus that > the bool should be a bitflag instead, but I guess that can be later. Agreed - I think the next flag added going forward will take us in that direction. > Also, should this not just be a new WebHitTestResult::Data constructor with > more arguments? Ugh... Yah, I guess so. I feel like leaving so much of it out in WebPageMac is terrible, but I suppose it's not too different from the status quo. Thanks!
Created attachment 250388 [details] Patch for landing
Comment on attachment 250388 [details] Patch for landing Clearing flags on attachment: 250388 Committed r182573: <http://trac.webkit.org/changeset/182573>