Bug 143502 - Expose the "Share" menu for links, images, and media
Summary: Expose the "Share" menu for links, images, and media
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Brady Eidson
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2015-04-07 16:49 PDT by Brady Eidson
Modified: 2015-11-17 02:50 PST (History)
7 users (show)

See Also:


Attachments
Not ready for review, EWS run - v1 (18.18 KB, patch)
2015-04-07 16:50 PDT, Brady Eidson
no flags Details | Formatted Diff | Diff
Not ready for review, EWS run - v2 (20.06 KB, patch)
2015-04-08 09:36 PDT, Brady Eidson
no flags Details | Formatted Diff | Diff
Still an evolving WIP, still want EWS on the other platforms - v3 (23.89 KB, patch)
2015-04-08 10:28 PDT, Brady Eidson
no flags Details | Formatted Diff | Diff
For EWS, v4 (36.22 KB, patch)
2015-04-08 12:05 PDT, Brady Eidson
no flags Details | Formatted Diff | Diff
For EWS, v5 (27.01 KB, patch)
2015-04-08 13:06 PDT, Brady Eidson
no flags Details | Formatted Diff | Diff
Patch for review, v1 (33.81 KB, patch)
2015-04-08 14:21 PDT, Brady Eidson
thorton: review+
Details | Formatted Diff | Diff
Patch for landing (31.39 KB, patch)
2015-04-08 14:56 PDT, Brady Eidson
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Brady Eidson 2015-04-07 16:49:45 PDT
Expose the "Share" menu for links, images, and media

In radar rdar://problem/20435340
Comment 1 Brady Eidson 2015-04-07 16:50:56 PDT
Created attachment 250315 [details]
Not ready for review, EWS run - v1
Comment 2 WebKit Commit Bot 2015-04-07 16:52:18 PDT
Attachment 250315 [details] did not pass style-queue:


ERROR: Source/WebKit/win/WebCoreSupport/WebContextMenuClient.h:48:  Tab found; better to use spaces  [whitespace/tab] [1]
Total errors found: 1 in 14 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Brady Eidson 2015-04-08 09:36:29 PDT
Created attachment 250356 [details]
Not ready for review, EWS run - v2
Comment 4 Brady Eidson 2015-04-08 10:28:13 PDT
Created attachment 250358 [details]
Still an evolving WIP, still want EWS on the other platforms - v3
Comment 5 WebKit Commit Bot 2015-04-08 10:30:20 PDT
Attachment 250358 [details] did not pass style-queue:


ERROR: Source/WebKit2/WebProcess/WebPage/WebPage.h:1089:  The parameter name "result" adds no information, so it should be removed.  [readability/parameter_name] [5]
ERROR: Source/WebCore/platform/ContextMenuItem.cpp:79:  Tab found; better to use spaces  [whitespace/tab] [1]
Total errors found: 2 in 19 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 6 Brady Eidson 2015-04-08 12:05:32 PDT
Created attachment 250367 [details]
For EWS, v4

As work continues, check on all the other builds again.
Comment 7 WebKit Commit Bot 2015-04-08 12:37:40 PDT
Attachment 250367 [details] did not pass style-queue:


ERROR: Source/WebKit2/WebProcess/WebPage/WebPage.cpp:4876:  Declaration has space between type name and * in Element *URLElement  [whitespace/declaration] [3]
ERROR: Source/WebKit2/WebProcess/WebPage/WebPage.cpp:4882:  Declaration has space between type name and * in NSDictionary *options  [whitespace/declaration] [3]
ERROR: Source/WebKit2/WebProcess/WebPage/WebPage.cpp:4917:  Declaration has space between type name and * in DDActionContext *actionContext  [whitespace/declaration] [3]
Total errors found: 3 in 20 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 8 Brady Eidson 2015-04-08 13:06:22 PDT
Created attachment 250379 [details]
For EWS, v5
Comment 9 Brady Eidson 2015-04-08 14:21:21 PDT
Created attachment 250386 [details]
Patch for review, v1
Comment 10 WebKit Commit Bot 2015-04-08 14:23:33 PDT
Attachment 250386 [details] did not pass style-queue:


ERROR: Source/WebCore/ChangeLog:8:  You should remove the 'No new tests' and either add and list tests, or explain why no new tests were possible.  [changelog/nonewtests] [5]
Total errors found: 1 in 27 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 11 Tim Horton 2015-04-08 14:30:19 PDT
Comment on attachment 250386 [details]
Patch for review, v1

View in context: https://bugs.webkit.org/attachment.cgi?id=250386&action=review

> Source/WebCore/platform/mac/ContextMenuItemMac.mm:207
> +        [items.get() addObject:(NSURL *)absoluteLinkURL];

none of these .get()s in message sends are required or desirable

> Source/WebKit2/WebProcess/WebPage/WebPage.h:873
> +    void populateWebHitTestResult(const WebCore::HitTestResult&, bool includeImage, WebHitTestResult::Data&);

I think it's pretty clear we're going to want to extend this and thus that the bool should be a bitflag instead, but I guess that can be later.

Also, should this not just be a new WebHitTestResult::Data constructor with more arguments?
Comment 12 Brady Eidson 2015-04-08 14:40:09 PDT
(In reply to comment #11)
> Comment on attachment 250386 [details]
> Patch for review, v1
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=250386&action=review
> 
> > Source/WebCore/platform/mac/ContextMenuItemMac.mm:207
> > +        [items.get() addObject:(NSURL *)absoluteLinkURL];
> 
> none of these .get()s in message sends are required or desirable

Duh!

> 
> > Source/WebKit2/WebProcess/WebPage/WebPage.h:873
> > +    void populateWebHitTestResult(const WebCore::HitTestResult&, bool includeImage, WebHitTestResult::Data&);
> 
> I think it's pretty clear we're going to want to extend this and thus that
> the bool should be a bitflag instead, but I guess that can be later.

Agreed - I think the next flag added going forward will take us in that direction.
 
> Also, should this not just be a new WebHitTestResult::Data constructor with
> more arguments?

Ugh...  Yah, I guess so. I feel like leaving so much of it out in WebPageMac is terrible, but I suppose it's not too different from the status quo.

Thanks!
Comment 13 Brady Eidson 2015-04-08 14:56:48 PDT
Created attachment 250388 [details]
Patch for landing
Comment 14 WebKit Commit Bot 2015-04-08 16:12:35 PDT
Comment on attachment 250388 [details]
Patch for landing

Clearing flags on attachment: 250388

Committed r182573: <http://trac.webkit.org/changeset/182573>