Bug 143485 - ContextMenuItem refactoring
Summary: ContextMenuItem refactoring
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Brady Eidson
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-04-07 10:29 PDT by Brady Eidson
Modified: 2015-04-07 15:14 PDT (History)
3 users (show)

See Also:

Attachments
Remove a default parameter (693 bytes, patch)
2015-04-07 10:31 PDT, Brady Eidson 		no flags Details | Formatted Diff | Diff
Try again to get win EWS to look at this. (693 bytes, patch)
2015-04-07 12:32 PDT, Brady Eidson 		no flags Details | Formatted Diff | Diff
Patch v1 (8.95 KB, patch)
2015-04-07 13:38 PDT, Brady Eidson 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Brady Eidson 2015-04-07 10:29:36 PDT 
ContextMenuItem refactoring to support "null item"

This will be a useful concept to have in ContextMenu refactoring and new features that use ContextMenu(Item)
Comment 1 Brady Eidson 2015-04-07 10:31:37 PDT 
Created attachment 250272 [details]
Remove a default parameter

Removing this default parameter in a ContextMenuItem constructor will determine whether I can immediately introduce a "ContextMenuItem()" constructor for the null item.

EWS will give me the answer!
Comment 2 Brady Eidson 2015-04-07 12:32:01 PDT 
Created attachment 250283 [details]
Try again to get win EWS to look at this.

Actually am concerned about Windows, need it ran by EWS.
Comment 3 Brady Eidson 2015-04-07 13:25:47 PDT 
Great, that works.

So I'll be adding here:
1 - An empty constructor and the concept of a "null menu item"
2 - Removing "releasePlatformDescription" from Mac (GTK still needs it)
3 - Renaming "getPlatformDescription"
Comment 4 Brady Eidson 2015-04-07 13:38:47 PDT 
Created attachment 250293 [details]
Patch v1
Comment 5 WebKit Commit Bot 2015-04-07 14:30:08 PDT 
Comment on attachment 250293 [details]
Patch v1

Clearing flags on attachment: 250293

Committed r182494: <http://trac.webkit.org/changeset/182494>
Comment 6 WebKit Commit Bot 2015-04-07 14:30:12 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 7 Brent Fulgham 2015-04-07 15:14:12 PDT 
This broke the Windows build:

..\platform\win\ContextMenuItemWin.cpp(34): error C2511: 'WebCore::ContextMenuItem::ContextMenuItem(void)' : overloaded member function not found in 'WebCore::ContextMenuItem' [C:\cygwin\home\buildbot\slave\win-release\build\Source\WebCore\WebCore.vcxproj\WebCore.vcxproj]
          C:\cygwin\home\buildbot\slave\win-release\build\Source\WebCore\platform\ContextMenuItem.h(187) : see declaration of 'WebCore::ContextMenuItem'