Bug 143483 – Fill list style background with same color with that of list background.

• Status: RESOLVED
• Resolution: FIXED
• Component: CSS

[ChangSeok Oh]

List style ignores selection background color.

[ChangSeok Oh]

Created attachment 250273 [details]
Patch

WIP

[ChangSeok Oh]

Created attachment 250341 [details]
Patch

[Simon Fraser (smfr)]

Comment on attachment 250341 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=250341&action=review

> LayoutTests/ChangeLog:9
> +        * fast/backgrounds/selection-background-color-of-image-list-style.html: Added.
> +        * fast/backgrounds/selection-background-color-of-list-style.html: Added.

It would be good if these could be reference tests instead.

> LayoutTests/fast/backgrounds/selection-background-color-of-list-style.html:3
> +ul>li::selection { background: red; }

Please don't use red in a passing test.

[ChangSeok Oh]

Comment on attachment 250341 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=250341&action=review

Thanks for your review.

>> LayoutTests/ChangeLog:9
>> +        * fast/backgrounds/selection-background-color-of-list-style.html: Added.
> 
> It would be good if these could be reference tests instead.

Hrm. I don't know a better way except pixel test. Is there a way to get background color of list style programmatically?

>> LayoutTests/fast/backgrounds/selection-background-color-of-list-style.html:3
>> +ul>li::selection { background: red; }
> 
> Please don't use red in a passing test.

Then green?

[ChangSeok Oh]

Though I could write a reference test, but I can create a perfectly matched expected.html. Reference test is too strict. I can't overcome 0.01% of difference between expected and actual. Is there anyway to suppress it?

[ChangSeok Oh]

(In reply to comment #5)
> but I can create a perfectly matched expected.html.
Sorry, %s/can/can't

[ChangSeok Oh]

Created attachment 250349 [details]
Patch

[Build Bot]

Comment on attachment 250349 [details]
Patch

Attachment 250349 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.appspot.com/results/6748241802559488

New failing tests:
fast/backgrounds/selection-background-color-of-image-list-style.html
fast/backgrounds/selection-background-color-of-list-style.html

[Build Bot]

Created attachment 250350 [details]
Archive of layout-test-results from ews101 for mac-mavericks

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews101  Port: mac-mavericks  Platform: Mac OS X 10.9.5

[Build Bot]

Comment on attachment 250349 [details]
Patch

Attachment 250349 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.appspot.com/results/5321318375358464

New failing tests:
fast/backgrounds/selection-background-color-of-image-list-style.html
fast/backgrounds/selection-background-color-of-list-style.html

[Build Bot]

Created attachment 250351 [details]
Archive of layout-test-results from ews106 for mac-mavericks-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews106  Port: mac-mavericks-wk2  Platform: Mac OS X 10.9.5

[ChangSeok Oh]

Weird. I don't know where the 0.01% difference come from. I'll bring back pixel test results and land it if no strong objection.

[ChangSeok Oh]

Created attachment 250353 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 250353 [details]
Patch

Clearing flags on attachment: 250353

Committed r182546: <http://trac.webkit.org/changeset/182546>

[ChangSeok Oh]

Patch landed. Close this.