Bug 143470 - [Content Filtering] Add logging
Summary: [Content Filtering] Add logging
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Andy Estes
URL:
Keywords:
Depends on:
Blocks: 128858
  Show dependency tree / graph
 
Reported: 2015-04-07 02:16 PDT by Andy Estes
Modified: 2015-04-07 13:49 PDT (History)
3 users (show)

See Also:

Attachments
Patch (15.09 KB, patch)
2015-04-07 02:18 PDT, Andy Estes 		dbates: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Andy Estes 2015-04-07 02:16:31 PDT 
[Content Filtering] Add logging
Comment 1 Andy Estes 2015-04-07 02:18:01 PDT 
Created attachment 250261 [details]
Patch
Comment 2 Daniel Bates 2015-04-07 13:39:21 PDT 
Comment on attachment 250261 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=250261&action=review

> Source/WebCore/testing/MockContentFilter.cpp:136
> +    LOG(ContentFiltering, "MockContentFilter stopped buffering with status %du at decision point %du.\n", m_status, decisionPoint);

Is %du a valid format specifier?
Comment 3 Andy Estes 2015-04-07 13:41:35 PDT 
(In reply to comment #2)
> Comment on attachment 250261 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=250261&action=review
> 
> > Source/WebCore/testing/MockContentFilter.cpp:136
> > +    LOG(ContentFiltering, "MockContentFilter stopped buffering with status %du at decision point %du.\n", m_status, decisionPoint);
> 
> Is %du a valid format specifier?

Eh, I probably just want %u.
Comment 4 Andy Estes 2015-04-07 13:49:28 PDT 
Committed r182489: <http://trac.webkit.org/changeset/182489>