Bug 143465 - [Win] Build errors in LocalizedStrings.cpp (newline in constant)
Summary: [Win] Build errors in LocalizedStrings.cpp (newline in constant)
Status: RESOLVED INVALID
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC Windows 8
: P2 Trivial
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-04-06 22:05 PDT by Sungmann Cho
Modified: 2015-07-08 17:48 PDT (History)
3 users (show)

See Also:

Attachments
Patch (5.13 KB, patch)
2015-04-06 22:40 PDT, Sungmann Cho 		achristensen: review-
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Sungmann Cho 2015-04-06 22:05:33 PDT 
On Windows, ToT currently breaks at:
    ..\platform\LocalizedStrings.cpp(250): error C2001: newline in constant
    ..\platform\LocalizedStrings.cpp(252): error C2001: newline in constant
    ..\platform\LocalizedStrings.cpp(250): fatal error C1057: unexpected end of file in macro expansion

In fact, this issue has already been reported in the past:
    https://lists.webkit.org/pipermail/webkit-help/2014-January/003705.html
Comment 1 Sungmann Cho 2015-04-06 22:40:46 PDT 
Created attachment 250257 [details]
Patch
Comment 2 Sungmann Cho 2015-04-09 23:03:10 PDT 
+benjamin@webkit.org for review.

@Benjamin: I followed your advice described in https://lists.webkit.org/pipermail/webkit-help/2014-January/003705.html.
Would you please take a look? Thanks.
Comment 3 Gyuyoung Kim 2015-04-22 01:01:16 PDT 
Comment on attachment 250257 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=250257&action=review

It seems this patch looks fine for me. However this patch should be reviewed by Mac or Win port reviewer. Benjamin and Alex, could you take a look ?

> Source/WebKit/mac/ChangeLog:3
> +        [Win] Fix build errors in LocalizedStrings.cpp (newline in constant).

It looks this file modifies mac port file. So I wonder if [Win] prefix is correct. Isn't it [Mac] ?
Comment 4 Alex Christensen 2015-04-22 06:35:44 PDT 
Comment on attachment 250257 [details]
Patch

I don't think we should just remove those quotation marks.  If we change this, it should probably be to "Look Up \"%@\"" and similar changes elsewhere.