Bug 143465 – [Win] Build errors in LocalizedStrings.cpp (newline in constant)

• Status: RESOLVED
• Resolution: INVALID
• Component: WebCore Misc.

[Sungmann Cho]

On Windows, ToT currently breaks at:
    ..\platform\LocalizedStrings.cpp(250): error C2001: newline in constant
    ..\platform\LocalizedStrings.cpp(252): error C2001: newline in constant
    ..\platform\LocalizedStrings.cpp(250): fatal error C1057: unexpected end of file in macro expansion

In fact, this issue has already been reported in the past:
    https://lists.webkit.org/pipermail/webkit-help/2014-January/003705.html

[Sungmann Cho]

Created attachment 250257 [details]
Patch

[Sungmann Cho]

[e-mail] for review.

@Benjamin: I followed your advice described in https://lists.webkit.org/pipermail/webkit-help/2014-January/003705.html.
Would you please take a look? Thanks.

[Gyuyoung Kim]

Comment on attachment 250257 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=250257&action=review

It seems this patch looks fine for me. However this patch should be reviewed by Mac or Win port reviewer. Benjamin and Alex, could you take a look ?

> Source/WebKit/mac/ChangeLog:3
> +        [Win] Fix build errors in LocalizedStrings.cpp (newline in constant).

It looks this file modifies mac port file. So I wonder if [Win] prefix is correct. Isn't it [Mac] ?

[Alex Christensen]

Comment on attachment 250257 [details]
Patch

I don't think we should just remove those quotation marks.  If we change this, it should probably be to "Look Up \"%@\"" and similar changes elsewhere.