Create the web inspector process pool lazily
Created attachment 250231 [details] Patch
Comment on attachment 250231 [details] Patch r=me
Comment on attachment 250231 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=250231&action=review > Source/WebKit2/UIProcess/WebInspectorProxy.cpp:310 > - static WebProcessPool* processPool = []{ > + if (!s_processPool) { > auto configuration = API::ProcessPoolConfiguration::createWithLegacyOptions(); > configuration->setProcessModel(ProcessModelMultipleSecondaryProcesses); > - return &WebProcessPool::create(configuration.get()).leakRef(); > - }(); > + s_processPool = &WebProcessPool::create(configuration.get()).leakRef(); > + }; One question: does this require initialize once semantics?
(In reply to comment #3) > > One question: does this require initialize once semantics? No, it doesn't require thread safe initialization.
Committed r182447: <http://trac.webkit.org/changeset/182447>
Comment on attachment 250231 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=250231&action=review > Source/WebKit2/UIProcess/WebInspectorProxy.cpp:318 > + if (!s_processPool) > + return false; I don’t think this code is needed. A null pointer would never be equal to the address of a reference.