Bug 143456 – Create the web inspector process pool lazily

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Anders Carlsson]

Create the web inspector process pool lazily

[Anders Carlsson]

Created attachment 250231 [details]
Patch

[Mark Lam]

Comment on attachment 250231 [details]
Patch

r=me

[Mark Lam]

Comment on attachment 250231 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=250231&action=review

> Source/WebKit2/UIProcess/WebInspectorProxy.cpp:310
> -    static WebProcessPool* processPool = []{
> +    if (!s_processPool) {
>          auto configuration = API::ProcessPoolConfiguration::createWithLegacyOptions();
>          configuration->setProcessModel(ProcessModelMultipleSecondaryProcesses);
> -        return &WebProcessPool::create(configuration.get()).leakRef();
> -    }();
> +        s_processPool = &WebProcessPool::create(configuration.get()).leakRef();
> +    };

One question: does this require initialize once semantics?

[Anders Carlsson]

(In reply to comment #3)
> 
> One question: does this require initialize once semantics?

No, it doesn't require thread safe initialization.

[Anders Carlsson]

Committed r182447: <http://trac.webkit.org/changeset/182447>

[Darin Adler]

Comment on attachment 250231 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=250231&action=review

> Source/WebKit2/UIProcess/WebInspectorProxy.cpp:318
> +    if (!s_processPool)
> +        return false;

I don’t think this code is needed. A null pointer would never be equal to the address of a reference.