WebKit1.SetAndUpdateCacheModelPreferencesChangeMix fails on some machines

[Alexey Proskuryakov]

The last subtest in WebKit1.SetAndUpdateCacheModelPreferencesChangeMix relies on the WebView to be deallocated/closed by webView.clear(). But this is not necessarily going to happen, because an autorelease pool can keep the view object alive until later.

    webView.clear();
    EXPECT_EQ((int)WebCacheModelDocumentViewer, (int)[WebView _cacheModel]); // <-- Only works when the above clear() drops the last reference.

Two ways to fix this:

1. Drain an autorelease pool before the check.

2. Call -close on the view explicitly.

I like the latter more, as it's the -close that we are actually after.

[Alexey Proskuryakov]

Created attachment 250219 [details]
proposed fix

[WebKit Commit Bot]

Comment on attachment 250219 [details]
proposed fix

Clearing flags on attachment: 250219

Committed r182434: <http://trac.webkit.org/changeset/182434>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.