Bug 143446 - Use content extensions in MiniBrowser
Summary: Use content extensions in MiniBrowser
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Alex Christensen
URL:
Keywords:
Depends on: 143459
Blocks:
  Show dependency tree / graph
 
Reported: 2015-04-06 11:12 PDT by Alex Christensen
Modified: 2015-04-07 10:08 PDT (History)
1 user (show)

See Also:

Attachments
Patch (31.61 KB, patch)
2015-04-06 11:20 PDT, Alex Christensen 		no flags Details | Formatted Diff | Diff
Patch (31.60 KB, patch)
2015-04-06 15:00 PDT, Alex Christensen 		no flags Details | Formatted Diff | Diff
Patch (31.78 KB, patch)
2015-04-06 17:43 PDT, Alex Christensen 		achristensen: review+
Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Alex Christensen 2015-04-06 11:12:46 PDT 
This makes testing easier.  Sam wrote the patch, but I'm uploading it.
Comment 1 Alex Christensen 2015-04-06 11:20:03 PDT 
Created attachment 250212 [details]
Patch
Comment 2 WebKit Commit Bot 2015-04-06 11:21:06 PDT 
Attachment 250212 [details] did not pass style-queue:


ERROR: Tools/MiniBrowser/mac/ExtensionManagerWindowController.m:26:  Found header this file implements before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted.  [build/include_order] [4]
Total errors found: 1 in 8 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Alex Christensen 2015-04-06 15:00:27 PDT 
Created attachment 250229 [details]
Patch
Comment 4 WebKit Commit Bot 2015-04-06 15:02:58 PDT 
Attachment 250229 [details] did not pass style-queue:


ERROR: Tools/MiniBrowser/mac/ExtensionManagerWindowController.m:26:  Found header this file implements before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted.  [build/include_order] [4]
Total errors found: 1 in 8 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 5 Alex Christensen 2015-04-06 17:43:02 PDT 
Created attachment 250247 [details]
Patch
Comment 6 WebKit Commit Bot 2015-04-06 17:44:44 PDT 
Attachment 250247 [details] did not pass style-queue:


ERROR: Tools/MiniBrowser/mac/ExtensionManagerWindowController.m:26:  Found header this file implements before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted.  [build/include_order] [4]
Total errors found: 1 in 8 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 7 Alex Christensen 2015-04-07 10:08:44 PDT 
recommitted to http://trac.webkit.org/changeset/182476 after fixing 32-bit build