WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
143440
Remove CSS functions min() and max() which had been dropped from specification
https://bugs.webkit.org/show_bug.cgi?id=143440
Summary
Remove CSS functions min() and max() which had been dropped from specification
Joonghun Park
Reported
2015-04-06 04:50:58 PDT
In the latest specification of CSS Values and Units Module Level3(
http://www.w3.org/TR/css3-values/
) min() and max() function had been dropped already during the CR period. So remove these css functions which not conform with the current specification.
Attachments
Patch
(2.40 KB, patch)
2015-04-06 04:54 PDT
,
Joonghun Park
no flags
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Joonghun Park
Comment 1
2015-04-06 04:54:19 PDT
Created
attachment 250200
[details]
Patch
Darin Adler
Comment 2
2015-04-06 09:07:48 PDT
Comment on
attachment 250200
[details]
Patch I don’t understand this patch. Is there a behavior change? Was this really the only code we had? No test covering it?
Joonghun Park
Comment 3
2015-04-07 23:39:47 PDT
(In reply to
comment #2
)
> Comment on
attachment 250200
[details]
> Patch > > I don’t understand this patch. Is there a behavior change? Was this really > the only code we had? No test covering it?
Yes, I think that's all of the calculation min() and max() related codes we have currently. If we choose to implement min() and max() functions which defined in
http://www.w3.org/TR/2011/WD-css3-values-20110906/#calc
it would needs patch like
https://bugs.webkit.org/show_bug.cgi?id=143515
, then LayoutTests/css3/calc/simple-minmax-expected.txt can be turned to pass result, but the latest specification of CSS Values and Units Module Level3 dropped those functions so I think the implementation of those are not needed anymore. :)
WebKit Commit Bot
Comment 4
2015-04-08 00:45:46 PDT
Comment on
attachment 250200
[details]
Patch Clearing flags on attachment: 250200 Committed
r182525
: <
http://trac.webkit.org/changeset/182525
>
WebKit Commit Bot
Comment 5
2015-04-08 00:45:51 PDT
All reviewed patches have been landed. Closing bug.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug