Bug 143435 - [Content Filtering] Add some additional unblock tests
Summary: [Content Filtering] Add some additional unblock tests
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Andy Estes
URL:
Keywords:
Depends on:
Blocks: 128858
  Show dependency tree / graph
 
Reported: 2015-04-05 20:27 PDT by Andy Estes
Modified: 2015-04-05 21:49 PDT (History)
4 users (show)

See Also:

Attachments
Patch (14.99 KB, patch)
2015-04-05 20:28 PDT, Andy Estes 		mitz: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Andy Estes 2015-04-05 20:27:40 PDT 
[Content Filtering] Add some additional unblock tests
Comment 1 Andy Estes 2015-04-05 20:28:58 PDT 
Created attachment 250189 [details]
Patch
Comment 2 mitz 2015-04-05 21:40:11 PDT 
Comment on attachment 250189 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=250189&action=review

> LayoutTests/contentfiltering/block-after-will-send-request-then-deny-unblock.html:6
> +    testContentFiltering(/* decisionPoint */settings.DECISION_POINT_AFTER_WILL_SEND_REQUEST, /* decision */settings.DECISION_ALLOW, /* decideAfterUnblockRequest */true);

Shouldn’t the decision here be DECISION_BLOCK?
Comment 3 Andy Estes 2015-04-05 21:43:20 PDT 
(In reply to comment #2)
> Comment on attachment 250189 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=250189&action=review
> 
> > LayoutTests/contentfiltering/block-after-will-send-request-then-deny-unblock.html:6
> > +    testContentFiltering(/* decisionPoint */settings.DECISION_POINT_AFTER_WILL_SEND_REQUEST, /* decision */settings.DECISION_ALLOW, /* decideAfterUnblockRequest */true);
> 
> Shouldn’t the decision here be DECISION_BLOCK?

Yes, it should be DECISION_BLOCK. Thank you for catching that!
Comment 4 mitz 2015-04-05 21:45:21 PDT 
Comment on attachment 250189 [details]
Patch

r=me with that fixed :)
Comment 5 Andy Estes 2015-04-05 21:49:37 PDT 
Committed r182376: <http://trac.webkit.org/changeset/182376>