Bug 143434 - Web Inspector: Add String/Array "includes" parameter display string
Summary: Web Inspector: Add String/Array "includes" parameter display string
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Joseph Pecoraro
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2015-04-05 18:33 PDT by Joseph Pecoraro
Modified: 2015-04-05 21:02 PDT (History)
9 users (show)

See Also:


Attachments
[PATCH] Proposed Fix (2.03 KB, patch)
2015-04-05 18:36 PDT, Joseph Pecoraro
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Joseph Pecoraro 2015-04-05 18:33:38 PDT
* SUMMARY
Add String/Array "includes" parameter display string.

* TEST
1. js> dir([])
2. Expand prototype
  => "includes" looks like it takes no parameters

* EXPECTED
"includes(searchElement, [startIndex=0])" like "indexOf"
Comment 1 Radar WebKit Bug Importer 2015-04-05 18:33:54 PDT
<rdar://problem/20430033>
Comment 2 Joseph Pecoraro 2015-04-05 18:36:51 PDT
Created attachment 250185 [details]
[PATCH] Proposed Fix
Comment 3 Darin Adler 2015-04-05 20:13:54 PDT
Comment on attachment 250185 [details]
[PATCH] Proposed Fix

View in context: https://bugs.webkit.org/attachment.cgi?id=250185&action=review

> Source/WebInspectorUI/UserInterface/Models/NativeFunctionParameters.js:37
> +        getOwnPropertySymbols: "object",

Not mentioned in change log.
Comment 4 WebKit Commit Bot 2015-04-05 21:02:36 PDT
Comment on attachment 250185 [details]
[PATCH] Proposed Fix

Clearing flags on attachment: 250185

Committed r182375: <http://trac.webkit.org/changeset/182375>
Comment 5 WebKit Commit Bot 2015-04-05 21:02:40 PDT
All reviewed patches have been landed.  Closing bug.