Bug 143430 - Use jsNontrivialString in more places if the string is guaranteed to be 2 or more characters
Summary: Use jsNontrivialString in more places if the string is guaranteed to be 2 or ...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-04-05 17:40 PDT by Joseph Pecoraro
Modified: 2015-04-08 18:39 PDT (History)
3 users (show)

See Also:

Attachments
[PATCH] Proposed Fix (4.20 KB, patch)
2015-04-05 17:40 PDT, Joseph Pecoraro 		darin: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Joseph Pecoraro 2015-04-05 17:40:01 PDT 
* SUMMARY
Use jsNontrivialString in more places if the string is guaranteed to be 2 or more characters.

* NOTES
- "NaN", "Infinity", and large values with "e" are guaranteed to have 2 or more characters
- Symbol's description string is guaranteed to at least have "Symbol()"
- A quoted string is guaranteed to have at least the two quotes
Comment 1 Joseph Pecoraro 2015-04-05 17:40:54 PDT 
Created attachment 250180 [details]
[PATCH] Proposed Fix
Comment 2 Darin Adler 2015-04-05 20:05:05 PDT 
Comment on attachment 250180 [details]
[PATCH] Proposed Fix

Symbol::descriptiveString should use makeString instead of StringBuilder.
Comment 3 Joseph Pecoraro 2015-04-08 18:39:11 PDT 
http://trac.webkit.org/changeset/182577
Comment 4 Joseph Pecoraro 2015-04-08 18:39:27 PDT 
(In reply to comment #2)
> Comment on attachment 250180 [details]
> [PATCH] Proposed Fix
> 
> Symbol::descriptiveString should use makeString instead of StringBuilder.

Will do this separately.