Bug 143428 – Web Inspector: Regression: Map instances don't expand

• Status: RESOLVED
• Resolution: FIXED
• Component: Web Inspector

[Nikita Vasilyev]

Created attachment 250175 [details]
Empty map

To reproduce:

var m = new Map;
for (var i = 0; i < 10; i++)
	m.set(i, "Zoidberg")
console.dir(m);


Map doesn't expand, the following error is thrown:

[Error] Uncaught exception in inspector page while dispatching callback for command Runtime.getCollectionEntries:  ReferenceError: Cannot access uninitialized variable. ReferenceError: Cannot access uninitialized variable.ObjectTreeMapEntryTreeElement@.../Views/ObjectTreeMapEntryTreeElement.js:33:9
ObjectTreeMapKeyTreeElement@.../Views/ObjectTreeMapEntryTreeElement.js:88:14
_updateEntries@.../Views/ObjectTreeView.js:255:87
_updateChildren@.../Views/ObjectTreeView.js:248:21
_updateChildren@[native code]
.../Resources/Protocol/RemoteObject.js:369:21
_dispatchCallback@.../Protocol/InspectorBackend.js:181:31
dispatch@.../Protocol/InspectorBackend.js:86:35
dispatchNextQueuedMessageFromBackend@.../Resources/Protocol/MessageDispatcher.js:42:34
	_dispatchCallback (InspectorBackend.js, line 183)
	dispatch (InspectorBackend.js, line 86)
	dispatchNextQueuedMessageFromBackend (MessageDispatcher.js, line 42)

[Radar WebKit Bug Importer]

<rdar://problem/20429794>

[Joseph Pecoraro]

I thought I had caught this in review.

    super(this._object, propertyPath);

Cannot use "this" before the super call. Easy fix.

[Joseph Pecoraro]

Created attachment 250179 [details]
[PATCH] Proposed Fix

[Brian Burg]

Comment on attachment 250179 [details]
[PATCH] Proposed Fix

r=me

Is this caught by an ESLint rule?

[WebKit Commit Bot]

Comment on attachment 250179 [details]
[PATCH] Proposed Fix

Clearing flags on attachment: 250179

Committed r182372: <http://trac.webkit.org/changeset/182372>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.