Bug 143421 - Remove "go ahead and" from comments
Summary: Remove "go ahead and" from comments
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Simon Fraser (smfr)
Depends on:
Reported: 2015-04-05 12:54 PDT by Simon Fraser (smfr)
Modified: 2015-04-05 13:19 PDT (History)
6 users (show)

See Also:

Patch (62.65 KB, patch)
2015-04-05 12:57 PDT, Simon Fraser (smfr)
darin: review+
benjamin: commit-queue-
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Simon Fraser (smfr) 2015-04-05 12:54:13 PDT
Remove "go ahead and" from comments
Comment 1 Simon Fraser (smfr) 2015-04-05 12:57:00 PDT
Created attachment 250161 [details]
Comment 2 Darin Adler 2015-04-05 13:09:48 PDT
Comment on attachment 250161 [details]

Commit queue: go ahead and land this patch.
Comment 3 Benjamin Poulain 2015-04-05 13:13:22 PDT
Comment on attachment 250161 [details]

View in context: https://bugs.webkit.org/attachment.cgi?id=250161&action=review

> Source/WebCore/loader/DocumentLoader.cpp:909
> +    // frame have any loads active, so and kill all the loads.

so and kill?

> Source/WebCore/platform/ScrollView.cpp:607
> +    // If we came in here with the view already needing a layout, then do that first.

I the comma useful here?

> Source/WebKit/mac/WebCoreSupport/WebFrameLoaderClient.mm:1637
> -        return ObjectContentFrame; // Go ahead and hope that we can display the content.
> +        return ObjectContentFrame; // Just hope that we can display the content.

Not convinced this one is an improvement.
Comment 4 Simon Fraser (smfr) 2015-04-05 13:18:52 PDT