Bug 143400 - Network cache Bloom filter is too big
Summary: Network cache Bloom filter is too big
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Page Loading (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2015-04-04 08:20 PDT by Antti Koivisto
Modified: 2015-04-05 08:23 PDT (History)
3 users (show)

See Also:

Attachments
patch (14.29 KB, patch)
2015-04-04 08:56 PDT, Antti Koivisto 		no flags Details | Formatted Diff | Diff
patch (14.94 KB, patch)
2015-04-04 11:57 PDT, Antti Koivisto 		cdumez: review+
Details | Formatted Diff | Diff
with a thread safety fix (14.99 KB, patch)
2015-04-05 02:56 PDT, Antti Koivisto 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Antti Koivisto 2015-04-04 08:20:54 PDT 
Switch from a counting filter to to a bit filter.
Comment 1 Radar WebKit Bug Importer 2015-04-04 08:21:26 PDT 
<rdar://problem/20426756>
Comment 2 Antti Koivisto 2015-04-04 08:56:37 PDT 
Created attachment 250127 [details]
patch
Comment 3 Antti Koivisto 2015-04-04 11:57:34 PDT 
Created attachment 250133 [details]
patch
Comment 4 Chris Dumez 2015-04-04 17:05:39 PDT 
Comment on attachment 250133 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=250133&action=review

Nice, r=me.

> Source/WebKit2/ChangeLog:51
> +2015-04-03  Antti Koivisto  <antti@apple.com>

Extra ChangeLog.

> Source/WebKit2/NetworkProcess/cache/NetworkCacheStorage.cpp:523
> +    // This was added already when starting the store but filter might have got wiped.

s/got/been/
Comment 5 Antti Koivisto 2015-04-05 02:56:53 PDT 
Created attachment 250154 [details]
with a thread safety fix
Comment 6 Antti Koivisto 2015-04-05 08:23:25 PDT 
https://trac.webkit.org/r182357