Bug 143391 - Reduce the dependency on Flash in regression tests
Summary: Reduce the dependency on Flash in regression tests
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Alexey Proskuryakov
Depends on:
Reported: 2015-04-03 16:19 PDT by Alexey Proskuryakov
Modified: 2015-04-06 09:32 PDT (History)
5 users (show)

See Also:

patch for EWS (25.30 KB, patch)
2015-04-03 16:31 PDT, Alexey Proskuryakov
no flags Details | Formatted Diff | Diff
patch (25.30 KB, patch)
2015-04-03 16:56 PDT, Alexey Proskuryakov
andersca: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Alexey Proskuryakov 2015-04-03 16:19:28 PDT
Flash is not necessarily installed on all machines, and when it is, it can be an old version that is blocked. All these differences can cause unexpected failures, depending on what you have installed.

We have a number of tests that use Flash, but somehow pass even when it is not installed. They must be not very good tests, given that they don't detect this fatal condition!

I'm going to clean up as much as I can, and to make WebKitTestRunner prevent attempts at using Flash in new tests.
Comment 1 Alexey Proskuryakov 2015-04-03 16:31:56 PDT
Created attachment 250104 [details]
patch for EWS

Chances are that I got at least a few cases wrong...

This also marks all remaining plugins/snapshotting tests as flaky, because they don't really test snapshotting at all, and just cause trouble. We would only be interested in crashes on these tests.
Comment 2 Alexey Proskuryakov 2015-04-03 16:56:23 PDT
Created attachment 250108 [details]
Comment 3 Alexey Proskuryakov 2015-04-03 18:10:15 PDT
Comment on attachment 250108 [details]

The patch fails to be applied (line endings?) 

But tests passed locally.
Comment 4 Anders Carlsson 2015-04-06 08:21:20 PDT
Comment on attachment 250108 [details]

Can you remove the .swf files?
Comment 5 Alexey Proskuryakov 2015-04-06 09:32:30 PDT
Committed <http://trac.webkit.org/r182428>.

> Can you remove the .swf files?

Not yet - they are still used in the 8 remaining tests that are skipped on WK2, but still run on WK1. We need to associate TestNetscapePlugin with an extension, and to make it load a resource to convert these.